GithubHelp home page GithubHelp logo

Comments (14)

rcarmo avatar rcarmo commented on June 20, 2024 3

Came here to report this as well. I would suggest running the migrations in CI to avoid pushing broken images to :latest, since for many projects that is effectively "stable".

from archivebox.

sclu1034 avatar sclu1034 commented on June 20, 2024 3

what's the diff between stable and latest please ?

I'd like to expand this question to all the alias tags. Because the deeper I dig, the more confusing it gets:

Like rcarmo said, the vast majority of projects I use consider :latest to mean "stable", and point it to the newest release version. So far, ArchiveBox seemed to be doing the same, as the occasional mention of a :dev tag in issues suggested that :latest was not a development build.

But now I've learned that there is also :stable, and that it's different from :latest. So apparently :latest is not a development build, but also not a release build. But checking the list of tags, :latest also isn't used by its literal name, as there is currently a nightly that's newer than :latest.

:stable itself does seem relatively straightforward and true to its name, as it's aliased to the newest versioned tag.

And then there's also :main, apparently, which by its name suggests to be "the one to be used primarily". But it doesn't actually point to :stable, but to :latest, even though the linked issue above uses :main and :stable in the same context (but does not use :latest, suggesting that :main might only sometimes be aliased to that).

And finally, :dev suggests by its name that it's an in-development build. But the current one is a month old, while both :stable and :latest are newer.

Moreover, I'd generally expect installation instructions to suggest the stable, production-ready version. But the Wiki uses :latest for the manual Docker section, and the recommended docker-compose.yml even uses :dev.


Ideally, the tags would be migrated to something that aligns with common practices (either ':latest == latest stable' or ':latest == any newest image'), but at the very least, there should be a page documenting all these aliases. And the installation instructions should probably be consistent in what image they use.

from archivebox.

pirate avatar pirate commented on June 20, 2024 3

Ok I just fixed all the tags manually, and I'm pushing the CI fixes next.

:latest == :stable == :0.7 == :0.7.2 == :sha-315c9f3 == :main

$ docker pull archivebox/archivebox:latest
$ docker run archivebox/archivebox:latest version
0.7.2
ArchiveBox v0.7.2 COMMIT_HASH=315c9f3 BUILD_TIME=2024-04-24 22:43:51 1713998631
...
$ docker pull archivebox/archivebox:stable
$ docker run archivebox/archivebox:stable version
0.7.2
ArchiveBox v0.7.2 COMMIT_HASH=315c9f3 BUILD_TIME=2024-04-24 22:43:51 1713998631
...
$ docker pull archivebox/archivebox:main
$ docker run archivebox/archivebox:main version
0.7.2
ArchiveBox v0.7.2 COMMIT_HASH=315c9f3 BUILD_TIME=2024-04-24 22:43:51 1713998631
...
$ docker pull archivebox/archivebox:0.7
$ docker run archivebox/archivebox:0.7 version
0.7.2
ArchiveBox v0.7.2 COMMIT_HASH=315c9f3 BUILD_TIME=2024-04-24 22:43:51 1713998631
...
$ docker pull archivebox/archivebox:0.7.2
$ docker run archivebox/archivebox:0.7.2 version
0.7.2
ArchiveBox v0.7.2 COMMIT_HASH=315c9f3 BUILD_TIME=2024-04-24 22:43:51 1713998631
...

These ^ are all built from the 315c9f3 commit (the 0.7.2 release commit from a few months ago), but as a side-effect of re-publishing them today, it bumped the unpinned dependency versions so it'll have the latest yt-dlp, chrome, wget, curl, etc. versions from 2024-04.


:dev == :sha-b4c3aa5 (for now, will updated once latest auth/import errors on dev branch are fixed)

$ docker pull archivebox/archivebox:dev
$ docker run archivebox/archivebox:dev version
0.7.3
ArchiveBox v0.7.3+editable COMMIT_HASH=b4c3aa5 BUILD_TIME=2024-03-26 22:15:46 1711491346
...

The docs and scripts now exclusively recommend archivebox/archivebox (aka :latest aka :stable):

I've entirely removed references to main in the docs, the stable branch will now be known as stable and the tag will be :stable (equivalent to :latest). (it was only ever main because Github recommended everyone switch away from the old master convention)

stable is just a better user-facing release channel name than main, so I'll centralize on that going forward and use it for both the Docker tag and Github branch name.

from archivebox.

rcarmo avatar rcarmo commented on June 20, 2024 2

from archivebox.

pirate avatar pirate commented on June 20, 2024 2

Ok thanks for your patience ya'll! Closing this for now.

btw the big PR that broke all these tags ^ is bringing some exciting new features soon, including the new REST API:

Screenshot 2024-04-25 at 3 56 38 AM

I'll roll a real release when it's stable, so you should all get it automatically when it's out!

from archivebox.

stanthewizzard avatar stanthewizzard commented on June 20, 2024 1

Watchtower running twice a day

from archivebox.

sclu1034 avatar sclu1034 commented on June 20, 2024 1

Daily watchtower runs for me also.

from archivebox.

Snyaify avatar Snyaify commented on June 20, 2024

same error after recent update :(

from archivebox.

stanthewizzard avatar stanthewizzard commented on June 20, 2024

same error after recent update :(

my archive default has the issue also

ConsequentlyI made a clean one with the errro too

from archivebox.

ddoroshev avatar ddoroshev commented on June 20, 2024

Looks like it caused by this recent commit (auth never imported).

Try image: archivebox/archivebox:stable (#1391, comment)

from archivebox.

stanthewizzard avatar stanthewizzard commented on June 20, 2024

archivebox/archivebox:stable
It works like a charm

thanks
what's the diff between stable and latest please ?

from archivebox.

Cinj216 avatar Cinj216 commented on June 20, 2024

Came here to report this as well. I would suggest running the migrations in CI to avoid pushing broken images to :latest, since for many projects that is effectively "stable".

THIS

from archivebox.

pirate avatar pirate commented on June 20, 2024

There is CI to handle all the tags as you'd expect but I broke it a couple ways with a recent big push, sorry all!

There are three issues that caused this:

  • I merged a big PR into main instead of dev yesterday by accident. It triggered a broken build getting tagged with :stable, :main, and :latest last night while I was asleep. (because main was the default branch and I didn't notice the PR wasn't based off dev, I've since fixed this)
  • Github Actions builds for :dev were succeeding but failing to tag them properly with the :dev tag, so that tag ended up stale. (working on the fix now)
  • I just added :stable recently because some users asked for it, it's not yet handled by CI at all I just manually tagged it to be equal to the latest stable version, hence it didn't break when the others broke (will be CI-handled in the future)

I'm working on fixing it right now. The final state should be:

  • :dev should be 1:1 with the dev branch, aka unstable and likely to break once or twice a month during busy months
  • :latest should be 1:1 with the :stable and the stable branch, wont be updated except for official mainline tagged version releases like 0.7, 0.7.1, etc.

from archivebox.

pirate avatar pirate commented on June 20, 2024

Out of curiosity, what setup are ya'll running that pulls new docker tags so quickly?

Are you using watchtower or some other auto-updater? And is the interval set to instant or daily?

Knowing how updates roll out and which users get them first helps me plan releases and tag updates in the future. (ArchiveBox collects no analytics, so even seemingly small info like this is very useful to me)

from archivebox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.