Comments (2)
pirate
commented on May 25, 2024
Woah good find, it looks like it's an old known issue in the cpython source:
python/cpython#84774 (comment)
while digging I found out urljoin actually has many unfortunate problems:
- different behavior depending on scheme: python/cpython#63028
- no support for non-standard schemes: python/cpython#110463
- incorrect handling of relative paths e.g.
../: python/cpython#96015 - poor arg type enforcement: python/cpython#63293
- incorrect handling of
?empty query param: python/cpython#76960 - incorrect handling of
#empty search param: python/cpython#83980 - other RFC compliance issues: python/cpython#43453
I wish we could use JS's new URL(part, base) behavior instead:
https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
from archivebox.
pirate
commented on May 25, 2024
Fixed in e5aba0d
from archivebox.
Related Issues (20)
- Feature Request: Raindrop.io import HOT 1
- htmltotext archive results are not recorded HOT 1
- parser=auto will almost always just fall back to parser=generic_txt, needs to let the first parser to find URLS win HOT 7
- Feature Request: Add config to show Snapshot.bookmarked timestamp instead of Snapshot.added in the UI
- New Extractor Idea: `forum-dl` for downloading forum threads as JSON/html HOT 1
- Feature Request: Add new `generic_jsonl` parser to support ingesting JSONL HOT 3
- Bug: `UnicodeEncodeError: 'utf-8' codec can't encode character '\udcf6' in position 110372: surrogates not allowed` when trying to render unprintable filesystem path in view HOT 15
- How to navigate various snapshots of a single url? HOT 2
- Support: podman-compose rootless setup leads to `PUID=0` being passed, and ArchiveBox refuses to start as root HOT 9
- Ability to disable archiving if not logged in HOT 3
- Support: Singlefile is failing to archive some sites (`xz.aliyun.com`) HOT 1
- Bug: Bilibili fails to scrape
- Support: singlefile & readability fail to work HOT 3
- Bug: Enter a valid URL. HOT 2
- Bug: AttributeError: 'PosixPath' object has no attribute 'split' / ImportError: attempted relative import beyond top-level package HOT 7
- New Feature: Provide deeper `mitmproxy` integration out-of-the-box in Docker HOT 1
- Bug: upgrading Docker image from 0.7.2 to 0.7.4 - The 0.7.4 version doesn't work HOT 3
- Feature Request: Create an ArchiveBox ingestion Slack bot
- Fix Docker image builds CI messing up `:latest`, `:stable`, and `:dev` tags HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from archivebox.