Mesh doesn't use custom logger about graphql-mesh

[kamilkowalski]

Ok, I found the issue - the logger option is documented¹ as:

Logger instance that matches Console interface of NodeJS

But in fact the resolveLogger function only uses that option if it's a string designating a module to be loaded.²

That's a bit confusing. Is the problem that of build vs runtime - so we can't really pass an instance because the config is only used to generate TypeScript artifacts so they need to contain the code that instantiated the logger?

I managed to work around it by passing a path to a TypeScript module in the logger option:

{
  logger: "./logger"
}

And doing the setup in that file. If it's impossible to pass an instance of the logger in config then I can update the type documentation, but I'd appreciate someone confirming this.

Footnotes

1. https://github.com/ardatan/graphql-mesh/blob/89c1abb9504bf785b3d11c23d2717a86806a428a/packages/legacy/types/src/config.ts#L56 ↩

2. https://github.com/ardatan/graphql-mesh/blob/89c1abb9504bf785b3d11c23d2717a86806a428a/packages/legacy/config/src/utils.ts#L276 ↩

[kamilkowalski]

Just noticed the above doesn't work for production builds because the import isn't handled correctly - Mesh tries to load the file from the .mesh directory instead of going up one directory similarly to how it handles additional resolvers.

[ardatan]

Actually that option is not supposed to an object as a logger. But a path to a code file that exports an object implements Logger from @graphql-mesh/types.
It is a missing documentation in that case.
But after build, if it doesn't load the module from the path correctly. This is a bug then.
Thanks for the feedback!
Apparently the types there and resolveLogger need to be fixed.
Would you try to tackle it in a PR?

[kamilkowalski]

I'll take a stab at it. 😊

[ardatan]

Thanks <3 ! Let us know if you need any questions and support!