areong / socket Goto Github PK

希望areong可以修复一下！

(Related pull request: #6)

Purpose

#3 and #4 report 100% CPU usage when SocketServer is listening to connections. This phenomenon should not happen. The phenomenon is probably caused by that the SocketServer keeps listening after a client is connected.

Method

Let the user decide how many connections a SocketServer is going to listen. Once the specified number of clients connected, the SocketServer stops listening.

To-do

• Rewrite the test code to verify the phenomenon.
  • Large CPU usage indeed happens. It happens on the server when the connected client is closed while the server is not yet closed.
  • I'm not sure if it is the same phenomenon stated in the two issues above.
  • One possible solution is to close the server after all connected clients were closed.
  • To define "all" clients, the upper limit of connection to a server should be specified, as stated in the purpose.
  • Update: A better solution is to close the corresponding connection thread once the connected client is closed. In this case, it does not matter whether there is an upper limit of the number of connections to a server.
• [ ] Let SocketServer only listen to a specified number of connections.

Method

Close the corresponding connection thread once the connected client is closed. Also remove the closed connection thread from the list.

• Socket.isClosed() will not be true until Socket.close() is called. That is, even the connected endpoint closes its socket, Socket.isClosed() on this side still returns false before Socket.close() is called.
• Socket.isConnected() is true after it is connected to another endpoint. It will still be true when the other endpoint closes.
• Use the first byte in the message sent from the client to tell the server if the connection should be closed.
• Remove not running ConnectionThreads.
• Merge the pull request and close this issue.

借用这个插件的时候，客户端和服务端分离，当服务端一直运行时，当每次新建一个客户端socket时，就会产生一个监听，然后监听一个连接，这样使用就会出现cpu使用100%的情况，使用jstack查了一下堆栈信息，发现监听线程和BufferedReader一直阻塞。然后我在BufferedReader接收消息然后回复后就马上关掉它，暂时保证CPU使用没有达到100%