arey / java-object-mapper-benchmark Goto Github PK

JMapper benchmark does not implement mapping for customerName field.
There is also no appropriate test, that can reveal the issue.

P.S. PR for the fix is in progress.

The OrderFactory currently only returns one case which could be seen as the most "happiest" case: nothing is null which introduces several issues:

• all the Mappers don't actually have to be implemented / defined in a null-safe manner. It's uncertain right now whether every implemented mapper is actually null safe (the tests don't cover that either). Each mappers null-safe declaration could also be way more verbose than it is right know which would skew the first impression how succinct / readable each mapping framework actually is in a nullable scenario
• the performance characteristics of each mapper could be drastically different for "unhappy" cases e.g. every field that should be mapped is null

I would propose the OrderManager to return a List<Order> which contains a happy, unhappy and middle case which is iterated for each mapper. Each Mapper will suffer in its final score if it handles one of those cases poorly. Maybe use an Order[] instead of a List<Order> to avoid skewing the results by having to instantiate an Iterator<Order> in each benchmark call. An extended for-loop on an array desugars into an indexed based loop that won't impact the results as much

Hello

I use https://github.com/remondis-it/remap because it check mapping at compile time and runtime

Could you add it in test

Best

The benchmarked version of Orika is old. The latest version supports a new BoundMapperFacade that brings substantial performance improvements.

A pull request addressing this issue is in the works.

Most mappers (Orika, BULL etc.) in this repository had new releases since the last benchmark run from february - let's get some up to date data and update the readme's table + image.

Enhance the model with more advanced features: enum mapping, transcoding, String to numeric conversion ...
The complexity is to implement thoses new features for all existing mappers.

Libraries used for this benchmark project are outdated, as well as JMH harness, and should be updated.
Corresponding PR is on the way.

Hi,

I read your article where you compare several mappers, I think that you can achieve interesting results by adding JMapper to the comparison.

https://github.com/jmapper-framework/jmapper-core

(i'm the founder)