argoproj-labs / rollouts-plugin-trafficrouter-gatewayapi

The Argo Rollouts plugin implementing the Kubernetes Gateway API specification for using different traffic providers in progressive delivery scenarios

Code:

Social:

Argo Rollouts Gateway API plugin

This repository is a plugin of Argo Rollouts for enabling the use of the Kubernetes Gateway API in Progressive Delivery scenarios.

See the main documentation site for all the details.

Feedback needed

The gateway API plugin should cover all providers that support it. If you find an issue please tell us about it

If you also want to add an example with your favorite gateway API provider please open a Pull Request.

rollouts-plugin-trafficrouter-gatewayapi's Issues

GRPCRoute support

Hi team!

I'm just curious if GRPCRoute support is on the roadmap for this plugin?

As the Gateway API is also graduated this Route to GA starting v1.1.0:

GRPCRoute has graduated to GA (v1) and is now part of the Standard Channel.

Thank you

Failed to run Gateway API plugin

I have installed the latest version of the argo-rollout controller and v0.0.1 gateway API plugin.
I have installed plugin using ConfigMap as follows

apiVersion: v1
kind: ConfigMap
metadata:
  labels:
    app.kubernetes.io/component: rollouts-controller
    app.kubernetes.io/name: argo-rollouts
    app.kubernetes.io/part-of: argo-rollouts
  name: argo-rollouts-config
data:
  trafficRouterPlugins: |-
    - name: "argoproj-labs/gatewayAPI"
      location: "https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.0.1/gateway-api-plugin-darwin-arm64"

Plugin is getting downloaded successfully but when I create a rollout I get the below error:

failed to get traffic router plugin argoproj-labs/gatewayAPI: unable to start plugin system: unable to get plugin client (argoproj-labs/gatewayAPI) for ping: exec: Stdout already set\n" error="<nil>"

docs: Add proper documentation site

The README is not enough anymore.

We should have a proper site like Argo Rollout and Argo CD based on ReadTheDocs

Support multiple HTTPRoute resources per rollout

It's possible that the same rollout might need to change backend weights in multiple HTTPRoute/TCPRoute resources.
I'm running into a situation, where I have multiple HTTPRoute resources per service and can only change one.

This is similar to argoproj/argo-rollouts#1100, which is about Istio VirtualService resources.

Example:

plugins:
  argoproj-labs/gatewayAPI:
    routes: 
      - kind: HTTPRoute
        name: first
      - kind: HTTPRoute
        name: second

or

plugins:
  argoproj-labs/gatewayAPI:
    httpRoutes: 
      - first
      - second

If you think it makes sense I'm up for contributing.

Gateway in a pending state - Kong Ingress Controller

Kong Ingress Controller -> 3.11

The Gateway is in a pending state -> Waiting for controller. Have followed the same steps as defined in the examples.

Update repo name

Hi @kostis-codefresh & @PhilippPlotnikov

Just wanted to make you were aware of argoproj/argo-rollouts#2720

We are updating the naming convention for plugins for rollouts.

So in your case, the repo would need to move to rollouts-plugin-trafficrouter-gatewayapi

I hope this isn't too much of an inconvenience.

SetMirrorRoute functionality support

If you would like to have SetMirrorRoute functionality.
Give it a 👍. We prioritize the issues with the most 👍

chore: Add integration tests

Currently we only have simple unit tests.

We should have integration tests like Argo Rollouts

Issue Integrating Kong with Argo Rollout

Hi Team

Faced one issue when integrating KIC with Argo Rollouts. This seems to be an issue with KIC, I did raise a ticket there too but wanted to check if this issue was come across when trying the demo with Kong

2024-03-06T17:09:44Z error Failed parsing resource errors {"url": "https://localhost:8444", "update_strategy": "InMemory", "error": "could not unmarshal config error: json: cannot unmarshal object into Go struct field ConfigError.flattened_errors of type []sendconfig.FlatEntityError"}

Got this error when httproute and rollout was configured.

KIC Issue for reference -> Kong/kubernetes-ingress-controller#5676

Rollouts Delete Timeout Setting

Timeouts that are set on the HTTPRoute seem to be deleted when Argo Rollouts makes updates to the HTTPRoute. The reference for the timeouts can be found here https://gateway-api.sigs.k8s.io/api-types/httproute/#timeouts-optional. It looks like potentially in the code the timeouts are not being pulled or copied over to the new definition.

Failed to run gateway-api plugin - rollouts/plugin-bin: read-only file system - with Argo Rollouts Helm chart

Argo-rollouts installed using helm chart:
https://artifacthub.io/packages/helm/argo/argo-rollouts

After mounting new configMap:

apiVersion: v1
kind: ConfigMap
metadata:
  name: argo-rollouts-config # must be so name
  namespace: argo-rollouts # must be in this namespace
data:
  trafficRouterPlugins: |-
    - name: "argoproj-labs/gatewayAPI"
      location: "https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.2.0/gateway-api-plugin-linux-amd64"

And restarting deployment:
kubectl rollout restart deployment -n argo-rollouts argo-rollouts

New pods dont work:

time="2024-07-01T14:46:38Z" level=info msg="Argo Rollouts starting" version=v1.7.0+6937996
time="2024-07-01T14:46:38Z" level=info msg="Creating event broadcaster"
2024-07-01T14:46:38.975517525Z time="2024-07-01T14:46:38Z" level=info msg="Setting up event handlers"
2024-07-01T14:46:38.975524925Z time="2024-07-01T14:46:38Z" level=info msg="Setting up experiments event handlers"
2024-07-01T14:46:38.975589514Z time="2024-07-01T14:46:38Z" level=info msg="Setting up analysis event handlers"
2024-07-01T14:46:38.979223324Z time="2024-07-01T14:46:38Z" level=fatal msg="Failed to download plugins: failed to create plugin folder for plugin (argoproj-labs/gatewayAPI): (mkdir /home/argo-rollouts/plugin-bin: read-only file system)"

Any hint whats next?

Config map ref broken while upgrading to 0.1.0 version from 0.0.1

Error from the argo-controller pods after upgrading to v0.1.0

time="2024-02-13T06:47:11Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=test-argo-gamma rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=info msg="Reconciling TrafficRouting with type 'GatewayAPI'" namespace=test-argo-gamma rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=error msg="roCtx.reconcile err failed to remove managed routes via plugin: configmaps \"argo-gatewayapi-configmap\" not found" generation=2 namespace=test-argo-gamma resourceVersion=348232258 rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=info msg="Reconciliation completed" generation=2 namespace=test-argo-gamma resourceVersion=348232258 rollout=gap-app-argo time_ms=23.592025
time="2024-02-13T06:47:11Z" level=error msg="rollout syncHandler error: failed to remove managed routes via plugin: configmaps \"argo-gatewayapi-configmap\" not found" namespace=test-argo-gamma rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=info msg="rollout syncHandler queue retries: 38 : key \"test-argo-gamma/gap-app-argo\"" namespace=test-argo-gamma rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=error msg="failed to remove managed routes via plugin: configmaps \"argo-gatewayapi-configmap\" not found\n" error="<nil>"

apiVersion: v1
kind: ConfigMap
metadata:
  name: argo-rollouts-config 
  namespace: argo-rollouts 
data:
  trafficRouterPlugins: |-
    - name: "argoproj-labs/gatewayAPI"
      location: "https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.1.0/gateway-api-plugin-linux-amd64"

Reverting back to v0.0.1 works fine.

Is there a ReadME with instructions for the upgrade to 0.1.0? How can I help?

SetHeader option support

Hi,
I was wondering if there is a plan or a roadmap for when the plugin will support the SetHeader option.
Thank you!