aristanetworks / avd-workshops Goto Github PK

This feature should be showcased during the AVD workshop. Render configuration, but do not push, as it will break the management connectivity to the switches in the ATD topology:

https://avd.sh/en/stable/docs/porting-guides/4.x.x.html?h=inband_mgmt#in-band-management-for-l2-switches

Hello Arista Engineering people,

On the heels of issue #148, I have a suggestion that the method for setting LABPASSPHRASE. For the students' benefit, it should still be explained early in the avd-lab-guide.md, but be made an (automatic) entry in the zsh config as a usability/life improvement when opening new shells. 😁

I'm game to include this in a PR (most likely along with #148 should that be blessed).

Thoughts?

Thank you!

Seen under the Ansible components section

• update output for correct ansible-core version
• Add note on main page to leverage with ATD or personal but needs additional requirements
• update official doc references to 4.5 (current build of workshops)
• Remove old lab credentials and replicate what students see
• Add ATD specific note
• Update ansible galaxy collection list output

Background:

At the end of the Git Section, there are instructions create a PR and Merge it to the main repo. Tech Leads are unable to actually do the merge operation creating some confusion at how to sync fork with the upstream repo.

Decision:

Add a note to inform the Tech Leads that the PR should actually be merged into main repo, else they will need to set the repo back for the next class. Explain to the students what would happen vs actually doing it.

Directory needs to be updated in the lab guide for the yml file location:

Site 2: https://aristanetworks.github.io/avd-workshops/avd-lab-guide/#site-2_1

Add the following code block to the bottom of sites/site_1/group_vars/SITE2_FABRIC.yml.

Current VLAN filter tags use numeric values for the VLAN. To eliminate confusion, we have decide to change the filter tags to something unrelated to the VLAN ID number.

These values need to be updated in the following locations:

Lab Repo - https://github.com/PacketAnglers/workshops-avd
The Guide - https://github.com/aristanetworks/avd-workshops
Presenter Slide Deck - Deck

Hello Arista Engineering people,

Along with #148 and #149...

There are two grammatical and content related items in avd-lab-guide.md I'd like to bring up for discussion.
Based on the outcome of our discussion I will submit a PR to cover the approved items. Thank you.

1. Change "Login to" to "Log into"

   • Login to your switches to verify the current configs (show run) match the ones created in intended/configs folder.

2. The line numbers no longer exactly correlate. Should the line number reference be updated or changed to a relative statement?

   • Starting at line 64, add the following code block into sites/site_1/group_vars/SITE1_FABRIC.yml.

3. Similar to item 2, the line number is no longer accurate.

   • Make sure the indentation of RACK3 is the same as RACK2, which can be found on line 52

In the check origin status, the single code block contains the command to run as well as the expected output. This added some confusion for some workshop attendees as they though the entire block was the command. Recommend putting the command in its own code block and adding a new section showing, this is the output, with the output in its own code block.

Verify the location of the remote copy. This should be your local GitHub account.

git remote -v

origin  https://github.com/xxxxxxx/ci-workshops-fundamentals.git (fetch)
origin  https://github.com/xxxxxxx/ci-workshops-fundamentals.git (push)

Show that we can number our Spines 1 through N, and then also number a Leaf nodes 1 through N.

Hello Arista Engineering people,

Mr. T asked me to put in issues before I open up PRs. I fully intend to open up PRs once suggestions are agreed upon. 😎

In both avd-lab-guide.md and cicd-basics.md there is an expression (piped shell commands) used to retrieve the LABPASSPHRASE from config.yaml. I have a suggestion that simplifies it greatly to exclusively an awk command.

Are you good with me submitting this as a PR?

Thank you!

No longer use include_vars. Instead we'll use the new AVD global_vars plugin for all global variables:

https://avd.arista.com/4.1/plugins/index.html?h=vars_pl#vars-plugins

Example:

➜  ci-workshops-avd git:(main) ✗ pre-commit run -a
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Break this into 2 code blocks like:

pre-commit run -a

Output:

trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Causes pipeline to intermittently fail

Arrows in image are incorrect

• file: ansible.md
• image: assets/images/ansible_playbook_anatomy.png

https://avd.arista.com/4.5/roles/eos_designs/docs/input-variables.html?h=same_subnet#fabric-ip-addressing

Fix markdown errors:

• MD033/no-inline-html: Inline HTML [Element: table]
• MD025/single-title/single-h1: Multiple top-level headings in the same document
• MD046/code-block-style: Code block style [Expected: fenced; Actual: indented]

The following sentence is a bit clunky.

Lists, which are sometimes also called sequences, are similar to arrays in development.
https://github.com/aristanetworks/avd-workshops/blob/main/workshops/jinja-yaml.md?plain=1#L172

In regard to the "in development" wording, was the message meant to be that lists in YAML are similar to arrays in other programming languages?

(I'm fine submitting a PR once this is sorted out.)
Maybe it could be written as:

Lists, sometimes called sequences, are similar to arrays in other programming languages.
or
Lists, sometimes called sequences, are similar to arrays in other programming languages and technologies.

Hi there! I was going through the CICD Basics workshop and I would like to suggest adding a small section explaining the prod.yml for GitHub Actions similar to the part about the dev.yml.

It could be before or after the following part in my opinion:

At this point, this will kick off our second workflow (prod.yml) against the main branch. This workflow will build and deploy our updates with CVP.

Then it would be clearer (at least for me) how GitHub Actions triggers CVP and creates tasks there. After checking the prod.yml file it was clear but I thought it's missing in the workshop. Other than that great job!

When user tries to merge the branch below, they receive this error because they forgot to uncheck copy the main branch only when forking the repo.

git merge origin/cicd-ff

Error Message:

merge: origin/cicd-ff - not something we can merge

Steps to fix the issue without re-forking the repo. This is useful if running a virtual workshop and users are having issues.

git remote add upstream https://github.com/aristanetworks/ci-workshops-avd.git
git fetch upstream
git merge upstream/cicd-ff

Hello there

Make it clear that the user needs to update ansible_ssh_pass in the following group_var:
WORKSHOP_FABRIC.yml (~/project/labfiles/ci-workshops-fundamentals/ansible/inventory/group_vars/WORKSHOP_FABRIC.yml)

https://aristanetworks.github.io/avd-workshops/ansible/#variables

For the CI/CD Lab Guide, let's add Step#'s for each section. This way we can refer to where we are when running a lab and make sure attendees have caught to Step# ....

https://aristanetworks.github.io/avd-workshops/cicd-basics/

This is already done on the AVD Lab Guide...

https://aristanetworks.github.io/avd-workshops/avd-lab-guide/

Hello Arista Engineering people,

💡 In the markdown there is an example for dev.yml that needs updated. The rest of this will be placed in an issue over in the main AVD repository.

I still had some time on the temporary ATD lab environment and couldn't resist working through the CI/CD section!
In going through that section I discovered that GitHub has made some changes to supported versions of Node.js so some versions of GitHub Actions need adjusted.

Please test that you too have issues with the GitHub Actions at the pinned versions the lab uses.
➡️ I'd be glad to submit a PR after receiving your blessing. Thank you!

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

In dev.yml I made the following changes:

uses: actions/checkout@v3 >> v4

uses: actions/setup-python@v3 >> v5

uses: dorny/paths-filter@v2 >> v3
(in two locations)

In prod.yml I made the same changes as dev:

uses: actions/checkout@v3 >> v4

uses: actions/setup-python@v3 >> v5

uses: dorny/paths-filter@v2 >> v3
(in two locations)

Additionally I've opened up an issue and eventually a PR against the aristanetworks/ci-workshops-avd repository.

In the CI/CD workshop, add an admonition with a link to the following GitHub Actions linter: https://rhysd.github.io/actionlint/

Edit will make flow easier for students

• Adjust this section of the AVD Lab guide to install AVD 4.5.0, and all requirements, into the lab environment:

https://aristanetworks.github.io/avd-workshops/avd-lab-guide/#step-1-prepare-lab-environment

• Run through AVD lab to make sure there are no issues

This is no longer required as the labs are now using a one-time token
https://aristanetworks.github.io/avd-workshops/git/#create-a-github-personal-access-token

Topics:

• Rebasing
• Merge Conflicts
• Undo Commits
• Home Base Branch
• Reset (Soft / Hard)

Code block starting line 948: Variable mismatch. Change vrf_params to vrf_values.

Line 986: Change _params to _values

Code block starting line 988: Variable mismatch. Change vrf_params to vrf_values.