aristanetworks / ownership-voucher-grpc

Ownership Voucher Grpc Service

ovgs.proto defines the service interface

ownership-voucher-grpc's Issues

GetSerialResponse.public_key_der should be public cert

I think that GetSerialResponse.public_key_der should be the certificate, obviously without the key, not the public key. I think this was a temporary limitation. How can both be accomodated for when that limitation is lifted?

RemoveUserRole does not specify behavior if a group_id, org_id, or user_type are empty

Is the org_id from the hierarchy assumed if empty?
If group_id is empty, is the username removed from all groups? If yes, is user_type matched? if not, what is the point of user_type in RemoveUserRole?

GetUserRoleRequest missing group_id field?

Also, I do not understand the usefulness of the user_type field in this request.

which PK?

Please be more specific in the comments about which PK is in GetOwnershipVoucherResponse.

https://github.com/aristanetworks/ownership-voucher-grpc/blob/main/ovgs.proto#L244

AddUserRoleRequest required fields

Are all fields of AddUserRoleRequest required? Or, is org_id assumed from the hierarchy if omitted?

AccountType needs more descriptive comments

Please add comments describing these values in greater detail. It is difficult to know what these mean without experience with CVaaS.

enum AccountType {
ACCOUNT_TYPE_UNSPECIFIED = 0;
ACCOUNT_TYPE_USER = 1;
ACCOUNT_TYPE_SERVICE_ACCOUNT = 2;
}

Other necessary documentation for ovgs.proto

DeleteGroup(): What error is returned if a group is not empty?
AddUserRole(): What is returned if the username, org_id, user_type (ie: the specific user) does not exist?
*Serial(): clean-up language after the creation of Component.
GetOwnershipVoucher(): what is component or cert_id do not exist?