aritsune / lancer-cc-uncle Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 6.0 1.04 MB

JavaScript 99.97% Procfile 0.03%

lancer-cc-uncle's People

Contributors

Stargazers

Watchers

Forkers

flukowski perijove mghill bscotty forevilporpoises msprijatelj

lancer-cc-uncle's Issues

[BUG] UNCLE Returns “Unknown Error” for some queries

Description
Sometimes, UNCLE will return an unknown error as a response to a compendium query.

Steps to Reproduce

Make a compendium query for [[Apocalypse Rail]] in a discord server+channel with UNCLE.
Observe an error response similar to the following:

An unknown error occurred. Incident code: `DiscordAPIError-1657544347192`
You shouldn't ever receive an error like this.
Please contact ari#6716.

Additional Context
I have only seen this with Apoc Rail so far, though there may be other entries with issues as well. Unsure if it’s limited to Apoc or more systemic.

Heroku deploy issues

Currently the stable deployed version of UNCLE is v31.
After doing these things:

It seems that new deploys to Heroku fail with this error:

2021-06-10T15:53:22.236368+00:00 heroku[bot.1]: State changed from crashed to starting
2021-06-10T15:53:27.048616+00:00 heroku[bot.1]: Starting process with command `node index.js`
2021-06-10T15:53:27.873128+00:00 heroku[bot.1]: State changed from starting to up
2021-06-10T15:53:30.431962+00:00 app[bot.1]: internal/modules/cjs/loader.js:888
2021-06-10T15:53:30.431988+00:00 app[bot.1]: throw err;
2021-06-10T15:53:30.431989+00:00 app[bot.1]: ^
2021-06-10T15:53:30.431989+00:00 app[bot.1]:
2021-06-10T15:53:30.431989+00:00 app[bot.1]: Error: Cannot find module '@sapphire/async-queue'
2021-06-10T15:53:30.431990+00:00 app[bot.1]: Require stack:
2021-06-10T15:53:30.431990+00:00 app[bot.1]: - /app/node_modules/discord.js/src/rest/RequestHandler.js
2021-06-10T15:53:30.431990+00:00 app[bot.1]: - /app/node_modules/discord.js/src/rest/RESTManager.js
2021-06-10T15:53:30.431991+00:00 app[bot.1]: - /app/node_modules/discord.js/src/client/BaseClient.js
2021-06-10T15:53:30.431991+00:00 app[bot.1]: - /app/node_modules/discord.js/src/index.js
2021-06-10T15:53:30.431992+00:00 app[bot.1]: - /app/node_modules/discord.js-commando/src/client.js
2021-06-10T15:53:30.431992+00:00 app[bot.1]: - /app/node_modules/discord.js-commando/src/index.js
2021-06-10T15:53:30.431992+00:00 app[bot.1]: - /app/index.js
2021-06-10T15:53:30.431993+00:00 app[bot.1]: at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)
2021-06-10T15:53:30.431993+00:00 app[bot.1]: at Function.Module._load (internal/modules/cjs/loader.js:730:27)
2021-06-10T15:53:30.431993+00:00 app[bot.1]: at Module.require (internal/modules/cjs/loader.js:957:19)
2021-06-10T15:53:30.431994+00:00 app[bot.1]: at require (internal/modules/cjs/helpers.js:88:18)
2021-06-10T15:53:30.431994+00:00 app[bot.1]: at Object.<anonymous> (/app/node_modules/discord.js/src/rest/RequestHandler.js:3:24)
2021-06-10T15:53:30.431994+00:00 app[bot.1]: at Module._compile (internal/modules/cjs/loader.js:1068:30)
2021-06-10T15:53:30.431995+00:00 app[bot.1]: at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
2021-06-10T15:53:30.431995+00:00 app[bot.1]: at Module.load (internal/modules/cjs/loader.js:933:32)
2021-06-10T15:53:30.431995+00:00 app[bot.1]: at Function.Module._load (internal/modules/cjs/loader.js:774:14)
2021-06-10T15:53:30.431996+00:00 app[bot.1]: at Module.require (internal/modules/cjs/loader.js:957:19) {
2021-06-10T15:53:30.431996+00:00 app[bot.1]: code: 'MODULE_NOT_FOUND',
2021-06-10T15:53:30.431996+00:00 app[bot.1]: requireStack: [
2021-06-10T15:53:30.431997+00:00 app[bot.1]: '/app/node_modules/discord.js/src/rest/RequestHandler.js',
2021-06-10T15:53:30.431997+00:00 app[bot.1]: '/app/node_modules/discord.js/src/rest/RESTManager.js',
2021-06-10T15:53:30.431997+00:00 app[bot.1]: '/app/node_modules/discord.js/src/client/BaseClient.js',
2021-06-10T15:53:30.431998+00:00 app[bot.1]: '/app/node_modules/discord.js/src/index.js',
2021-06-10T15:53:30.431998+00:00 app[bot.1]: '/app/node_modules/discord.js-commando/src/client.js',
2021-06-10T15:53:30.431998+00:00 app[bot.1]: '/app/node_modules/discord.js-commando/src/index.js',
2021-06-10T15:53:30.431999+00:00 app[bot.1]: '/app/index.js'
2021-06-10T15:53:30.431999+00:00 app[bot.1]: ]
2021-06-10T15:53:30.431999+00:00 app[bot.1]: }
2021-06-10T15:53:30.509752+00:00 heroku[bot.1]: Process exited with status 1
2021-06-10T15:53:30.649225+00:00 heroku[bot.1]: State changed from up to crashed
2021-06-10T15:53:30.661548+00:00 heroku[bot.1]: State changed from crashed to starting
2021-06-10T15:53:35.079827+00:00 heroku[bot.1]: Starting process with command `node index.js`
2021-06-10T15:53:35.952008+00:00 heroku[bot.1]: State changed from starting to up
2021-06-10T15:53:38.715649+00:00 app[bot.1]: internal/modules/cjs/loader.js:888
2021-06-10T15:53:38.715691+00:00 app[bot.1]: throw err;
2021-06-10T15:53:38.715692+00:00 app[bot.1]: ^
2021-06-10T15:53:38.715692+00:00 app[bot.1]:
2021-06-10T15:53:38.715693+00:00 app[bot.1]: Error: Cannot find module '@sapphire/async-queue'
2021-06-10T15:53:38.715693+00:00 app[bot.1]: Require stack:
2021-06-10T15:53:38.715694+00:00 app[bot.1]: - /app/node_modules/discord.js/src/rest/RequestHandler.js
2021-06-10T15:53:38.715694+00:00 app[bot.1]: - /app/node_modules/discord.js/src/rest/RESTManager.js
2021-06-10T15:53:38.715694+00:00 app[bot.1]: - /app/node_modules/discord.js/src/client/BaseClient.js
2021-06-10T15:53:38.715695+00:00 app[bot.1]: - /app/node_modules/discord.js/src/index.js
2021-06-10T15:53:38.715695+00:00 app[bot.1]: - /app/node_modules/discord.js-commando/src/client.js
2021-06-10T15:53:38.715695+00:00 app[bot.1]: - /app/node_modules/discord.js-commando/src/index.js
2021-06-10T15:53:38.715696+00:00 app[bot.1]: - /app/index.js
2021-06-10T15:53:38.715696+00:00 app[bot.1]: at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)
2021-06-10T15:53:38.715697+00:00 app[bot.1]: at Function.Module._load (internal/modules/cjs/loader.js:730:27)
2021-06-10T15:53:38.715697+00:00 app[bot.1]: at Module.require (internal/modules/cjs/loader.js:957:19)
2021-06-10T15:53:38.715697+00:00 app[bot.1]: at require (internal/modules/cjs/helpers.js:88:18)
2021-06-10T15:53:38.715698+00:00 app[bot.1]: at Object.<anonymous> (/app/node_modules/discord.js/src/rest/RequestHandler.js:3:24)
2021-06-10T15:53:38.715699+00:00 app[bot.1]: at Module._compile (internal/modules/cjs/loader.js:1068:30)
2021-06-10T15:53:38.715699+00:00 app[bot.1]: at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
2021-06-10T15:53:38.715699+00:00 app[bot.1]: at Module.load (internal/modules/cjs/loader.js:933:32)
2021-06-10T15:53:38.715700+00:00 app[bot.1]: at Function.Module._load (internal/modules/cjs/loader.js:774:14)
2021-06-10T15:53:38.715700+00:00 app[bot.1]: at Module.require (internal/modules/cjs/loader.js:957:19) {
2021-06-10T15:53:38.715701+00:00 app[bot.1]: code: 'MODULE_NOT_FOUND',
2021-06-10T15:53:38.715701+00:00 app[bot.1]: requireStack: [
2021-06-10T15:53:38.715701+00:00 app[bot.1]: '/app/node_modules/discord.js/src/rest/RequestHandler.js',
2021-06-10T15:53:38.715702+00:00 app[bot.1]: '/app/node_modules/discord.js/src/rest/RESTManager.js',
2021-06-10T15:53:38.715702+00:00 app[bot.1]: '/app/node_modules/discord.js/src/client/BaseClient.js',
2021-06-10T15:53:38.715702+00:00 app[bot.1]: '/app/node_modules/discord.js/src/index.js',
2021-06-10T15:53:38.715703+00:00 app[bot.1]: '/app/node_modules/discord.js-commando/src/client.js',
2021-06-10T15:53:38.715703+00:00 app[bot.1]: '/app/node_modules/discord.js-commando/src/index.js',
2021-06-10T15:53:38.715703+00:00 app[bot.1]: '/app/index.js'
2021-06-10T15:53:38.715704+00:00 app[bot.1]: ]
2021-06-10T15:53:38.715704+00:00 app[bot.1]: }
2021-06-10T15:53:38.819151+00:00 heroku[bot.1]: Process exited with status 1
2021-06-10T15:53:39.136462+00:00 heroku[bot.1]: State changed from up to crashed

async-queue is required by discord.js and no other libraries; it's included in the package-lock.json, and works locally. It does not work on Heroku, however. It may be related to faulty pruning of devDependencies. Leaving this here as a placeholder.

discord.js breaking API changes from v12 to v13

When discord.js updated from v12 to v13 they introduced a number of breaking changes, most notably changing resolveString to verifyString -- discordjs/discord.js#4880

discord-js-commando has not been updated to include verifyString yet: discordjs/Commando#402

As a consequence, we have to use the older version of discord.js / the most recent version of discord.js v12.

compare string lengths and take which one is longer (might error in certain cases...)
use discord features (a button which you click to expand the action section) -- this fundamentally breaks the flow of UNCLE (format->all formatted text is returned to user) so is a bigger lift

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.