arjangassadi / url2mhtml Goto Github PK

What steps will reproduce the problem?

The problem is with the boundary marker when embedding content. This can be 
fixed with a code change.

What is the expected output? What do you see instead?

Expected output is a working mht archive. What I'm getting instead is an 
invalid mht file.


What version of the product are you using? On what operating system?

The only version available.

Please provide any additional information below.

This issue can be fixed by adjusting the following:

In builder.cs, update the AppendMhtBoundary function

private void AppendMhtBoundary(bool end = false)
{
    // I have replaced " ", with "". look into this later.
    AppendMhtLine(string.Empty);
    if (end == true)
    {
        AppendMhtLine("--" + _MimeBoundaryTag + "--");
    }
    else
    {
        AppendMhtLine("--" + _MimeBoundaryTag);
    }
    //AppendMhtLine(" ");
}

and the AppendMhtFiles function

private void AppendMhtFiles()
{
    foreach (DictionaryEntry de in WebFiles)
    {
        WebFile ef = (WebFile)de.Value;
        AppendMhtFile(ef);
    }
    AppendMhtBoundary(true);
}


This makes sure that the last embedded object adds the necessary "--" onto the 
end of the boundary marker.

 BWhat steps will reproduce the problem?
1. By the history this has been laying in the boneyard since 1998.
2. Others like Microsoft IE currently use it since iit is current html code.  
Google Chrome isn't using it yet. 
3.  Google Chrome still makes a shortcut and a folder full of parts as bad as a 
disorganized hardware store. 

What is the expected output? What do you see instead?
An url saved to one file instead of a shortcut and a folder holding everything 
under the sun. 

What version of the product are you using? On what operating system?

Current public Google Chrome available 7/28/2010 running on Microsoft XP.

Please provide any additional information below.

This is one of two Google Chrome missing items that occasionally almost makes 
me uninstall Google Chrome and go back to Internet Explorer.