ark-builders / ark-rate Goto Github PK

Currency should be represented uniformly at any screen by:

• Short name (3-4 characters)
• Pictogram (unique text-like symbol)
• Country flag

Users must be able to configure what of these 3 things they want to see, e.g. only pictogram or flag + short name.

Settings: Digits start from multiple zeros e.g. 0000000955 can be shown/saved in Fiat/fiat rate round or Crypto/crypto rate round or Fiat/crypto rate round that is not correct.

Workaround: Click Quick or Assets or Alerts. Click Settings. Now zeros are removed and e.g. 955 is shown that is correct.

Quick: For few currencies, names are missing in Search e.g. AAVE, BTC, ETH etc.

related to #16
Work Manager not working when app is killed

Each currency should have clear symbols/graphics attached:

• Pictogram, i.e. small text-like symbols denoting the currency
• Flag of the country which uses the currency

If pictograms can be provided by unicode, then we can use it. But what I've found here doesn't make a lot of sense to me. E.g. Turkish Lyra is correct: ₺ but Kazakhstan Tenge is wrong: лв

The Portfolio data is crucial to the user. While it's frequently feasible for users to manually recover it, discovering that financial data has been lost due to an upgrade or other circumstances can be frustrating.

We have two options here:

• Store the data within the standard Android app folder.
• Allow users to select a preferred folder for data storage.

While both options facilitate future device synchronization, the latter also enables the use of third-party syncing mechanisms, adding an extra layer of versatility.

Let's have similar SonarCloud integration:

• ARK-Builders/arklib-android#105

Similar to ARK-Builders/ARK-Navigator#78

In the Portfolio screen, designed for multi-input calculation, we should introduce the concept of base currencies. These are one to three user-chosen currencies, deemed as familiar or native. For example, it could be USD, RUB and KZT. The intent is that each screen input should carry a hint, illustrating the equivalent amount in the base currencies.

To achieve this, we propose:

1. An additional [add_base] button.
2. Helpful hints adjacent to each input.
3. A dialog enabling the modification of base currencies set. A limit of three currencies seems reasonable.

The summary function should maintain its current operation.

Alerts: Same pair can be added multiple times that is not correct.

The current screen with multiple inputs is not very convenient when the user want to estimate value of single currency.

Quick Estimation screen should be implemented:

• [currencies] — a group of most recently used currencies
• [search] — a button for finding arbitrary currency

Each currency within [currency] is presented as clickable fav which invokes quick estimation dialog:

• [amount] — an input field for entering the selected currency amount
• [calculate] — a button for displaying the summary screen

Summary screen should act same as now, but with only one selected currency.

Each row has [remove] button which removes the currency left to it. We need [clear] button instead or in addition. This button would just erase value in the field instead of removing the currency.

Difficult to reproduce, because offline mode works and online mode with good connection works as well.

When internet connection is flaky, the app can load without added currencies. This must not happen, because the currencies and latest known exchange rates are stored locally.

Quick: Convert to currency added or deleted for one currency automatically applies to other currencies as well that is not correct.

e.g. Both KRW and GBP have base currencies USD and KZT. We delete base currency KZT from GBP, it disappears from KRW too.

https://github.com/ARK-Builders/ARK-Rate/pull/13/files/3ab38d7d0f286ad24a388faa69d251fcff49dfb7#diff-3356bc53a97bf9b7871002de7206cd61868a871759da3c49c1d29fa3dfba4c52R40

When we convert crypto assets, we use only those pairs, which have USD as one side of the pair. In other words, we always convert one crypto token to another via USDT. We could achieve more realistic conversion if we store all pairs in memory and first attempt to find direct match, before converting via USDT as a fallback.

Bonus points for advanced routing, e.g. ATOM -> DOT -> BTC.

At the moment, the app quits to background. It must return to previous screen instead.

• Build instructions
• Explain how we use https://github.com/ARK-Builders/ark-exchange-rates

Settings: App crashes on entering and saving 10 digits e.g. 2222222222 in Fiat/fiat rate round, Crypto/crypto rate round, Fiat/crypto rate round.

When plus button is clicked, the app crashes sometimes.

The feature should allow user to set alarm for specific price of an asset. In any other token, without necessity to convert via USDT.

Example:

1. Current price of ATOM is 2 DOT tokens.
2. The user sets alarm for ATOM/DOT pair, for the value of 3.
3. If price becomes 3 or more (e.g. 3.1), the user must receive a notification.

The feature should allow user to track some currency pair, recording time-based log of exchange rates. Later, the user should be able to see the plot. This would allow user to monitor custom exchange pairs, e.g. ATOM/DOT which is not very common pair on exchanges.

Quick: When any new currency is added then convert to currency for previously added currencies is automatically shown for this currency that is not correct.

Note: Each currency and its convert to currencies should be independent.

It's possible to press [convert] button if base currencies list contains only source currency.

Example:

Input: 999 GEL
Base currencies: GEL
Output: 999 GEL 

Currently, the only method to add a currency is by entering its exact three-letter code.

From a UX standpoint, this is suboptimal because:

• Users may not always know the code.
• The sequence of letters in the code can be easily confused.

Optimizing the process to allow currency addition by their colloquial name would greatly enhance the experience:

• USD — dollar
• RUB — ruble
• KRW — won
• KZT — tenge

Additionally, incorporating typo tolerance and localized input can significantly boost usability.

User types their query, e.g. "dollar".
App displays all possible currencies matching "dollar":

• Australian dollar
• Canadian dollar
• US dollar
  etc.

We need to ensure that the list contains only currencies which user can add.
We must filter already added currencies.

Settings/Quick: Go to Settings. Enter and save 9 digits e.g. 123456789 in Fiat/fiat rate round or Crypto/crypto rate round or Fiat/crypto rate round. Go to Quick. Click any added currency. Enter any amount. Add some currency for conversion. Click Convert. App crashes.

Alternatives should be switchable by a 2-state button:

• Plain list of currencies
• New 3D sphere-like widget

Each currency could be represented by several things grouped into a single item:

• #29

While multi-input may not be ideal for swift calculations, it's perfectly suited for maintaining portfolios.

Let's refer to it as the Portfolio screen since this moment.

We could refactor it in the following way:

• #31
• #32
• #33

In the absence of an internet connection, users must be informed that their exchange rates might not be up-to-date.

Additionally, users should be informed of the exact time when the rates were last updated. For this, we need to source such data from https://github.com/ARK-Builders/ark-exchange-rates.

On the notification screen, input fields should only become visible only after the user pressed [add] button. In the absence of existing alerts, only the [add] button should be displayed, without the input group.

When the keyboard appears, it may obscure some input fields.

Originally posted by @P-Melnik in ARK-Builders/website#4 (comment)

Quick: Click any added currency. Don't enter any amount. Add some currency for conversion. Click Convert. It doesn't ask to enter any amount and converts for zero (0) that is not correct.

Incorporating a feature to identify the currencies of a user's current location and neighboring countries would greatly assist travelers.

It would be great to enable users to create multiple tabs:

• keeping distinct portfolios separately
• temporary tabs for quick calculations

Settings/Assets: Go to Settings. Enter and save 9 digits e.g. 123456789 in Fiat/fiat rate round or Crypto/crypto rate round or Fiat/crypto rate round. Go to Assets. Click Summary. App crashes.

The Summary screen currently presents an overwhelming amount of flatly arranged information. We should categorize entries under respective currencies, allowing users to expand any of them.

User should be able to edit preferences.

First preference to add — numbers rounding:

• Rounding of rates for (crypto, crypto) and (crypto, fiat) pairs
  should be OFF by default

• Rounding of rates for (fiat, fiat) pairs
  should be ON by default

Basically, the app must perform multi-conversion of currencies.
E.g. we have 2 USD, 3 EUR, 1000 RSD and 250 TRY.
This is "input" of our multi-conversion.

For the conversion we need 6 exchange rates:

• USD-EUR (0.98 at July 19, 2022)
• USD-RSD (115.5 at July 19, 2022)
• USD-TRY (17.48 at July 19, 2022)
• EUR-USD (the same as USD-EUR)
• EUR-RSD (117.4 at July 19, 2022)
• EUR-TRY (17.76 at July 19, 2022)
• RSD-USD (the same as USD-RSD)
• RSD-EUR (the same as EUR-RSD)
• RSD-TRY (0.15 at July 19, 2022)
• TRY-... (repeating one of the above)

The output would be list of conversions of total amount (2 USD + 3 EUR + 1000 RSD + 250 TRY) into each of the currency USD, EUR, RSD or TRY separately:

• 28.01 USD
• 27.38 EUR
• 3215.3 RSD
• 492.08 TRY

The app must consist of 2 screens:

1. "Input" screen — list of currencies user has.

• There must be a list of currency inputs:
  • each row has number input, default is 0, no need to save the input between app launches
  • each row has currency symbol or abbreviation ($ or USD for U.S. dollars)
  • each row has [-] button for deleting the currency
• There must be a button [next], which loads next screen (passing user inputs into it).

2. "Output" screen - result of conversion.
   This screen accepts all user inputs from "Input" screen.

• There must be a list of all currency outputs:
  • each row (for currency T):
    • has list of exchange rates, i.e. for each currency S, exchange rate between S and T must be displayed
    • all "input" currencies must be converted into currency T and summed up
    • total number must be displayed
• There must be a button [back], which loads previous screen

3. Both screens must have [add_curr] button, presenting a dialog for adding new currency to the lists:
   • the dialog has drop-down list for choosing currency
   • the dialog has [add] button saving the choice
     • after adding, list of currencies must contain new row with corresponding currency
     • selected currencies must be stored between app launches
   • the dialog has [x] button for closing it without changes

List of chosen currencies is the same in "Input" and "Output" screen, must be saved into user data and be loaded during next app startup. Exchange rates must be taken from good source like Bloomberg, but can be other source if it's API is better.

https://github.com/ARK-Builders/cache-exchange-rates