arn00s / cariocamenu Goto Github PK

Firstly, thank you for an awesome library! Great work!
It would be great to have a similar library for android.

Has this library been ported to android or is there a similar looking library for android that you're aware of?

Hey, I am trying to dismiss presented ViewController but instead on dismissing, it goes to Carioca's default viewcontrollerViewController. My initial ViewController is UINavigationController but I do not think that is an issue. Is it a bug or I am stupid?

And this is how I present:

let emptyViewController = EmptyViewViewController.fromStoryboard()
present(emptyViewController, animated: true, completion: nil)

Would you be willing to add carthage support for this?

I tried to run the Demo project, but it does not respond to pan gesture in the menu, could you check this?
just try to run it :)
Very thanks, I may use this library on the app I'm developing, and once then, I'll give you the link ❤️

What did I do?

• Downloaded the demo project and ran it on iPhone 6s with iOS 11.2.1 without any modification.
• Travelled between content pages many times. (Not to be a prick, just to present the menu to my collegues.)

What happened?

• Memory usage gone beyond 150 MB.

Any ideas?

I traced the memory usage while travelling between pages. I saw 2 things.

• WebView data is not released when you go to another page.
• MapView data is released but not completely when you go to another page.

I don't know if these are issues about the menu, or something else, but false alarm better than no alarm :]

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[test.MainViewController cariocaMenuDidSelect:indexPath:]: unrecognized selector sent to instance 0x7ffa48e00be0'

this happen when ever I click on cell for the menu.

how change color of the button?

The library doesn't handle well when rotating the screen.

Steps to reproduce

• In portrait mode (Unlock rotation)
• Open the menu
• Scroll to About
• Open the menu again
• Rotate to landscape

Expected result

• The Menu Centered in landscape mode

Actual Results

• The Menu is half visible. (If you play it a couple of time, the menu button will disappear)

[x] There is no issue opened before about this.
[x] Issue is reproduceable in demo project.

What did I do?

• Downloaded the demo project.
• Wanted to check how it works with many menu items, so I copy pasted default menus 3 times. (4 times menu items at the end.) Change nothing else.
• Ran on iPhone 6s with iOS 11.2.1

What happened?

• CaroicaGestureManager.swift file, panned(yLocation:, edge:, state:, fromGesture:)method, line 76
• let yRange: ClosedRange<CGFloat> = 20.0...frameHeight - container.menuHeight
• Fatal error occured: Thread 1: Fatal error: Can't form Range with upperBound < lowerBound.
• Reason: With 4x menu items, container.menuHeight became greater than frameHeight I suppose.

I can help modify the code to allow changing shape color. currently it's hard coded

Hey! I am trying to apply icon instead of emoji but the problem is that the icon is way too big. This is how I add icon:

var menuItems: [CariocaMenuItem] = [
        CariocaMenuItem("Test1", .icon(UIImage(named: "test1Icon")!)),
        CariocaMenuItem("Test2", .icon(UIImage(named: "test2Icon")!))
    ]

This is the output:

My icon is 15x15

Cocoapods support and will be good to see social sharing in this menu.