arpitbbhayani / ls

Implement UNIX Shell command ls using UNIX System calls

Compile : run make

Execute : ./a.out [OPTION]... [FILE]...

Options implemented:

• a do not ignore entries starting with .
• d list directory entries instead of contents.
• l use a long listing format
• R list subdirectories recursively
• S sort by file size
• t sort by modification time

Features implemented :

• Coloring
• Output formatting
• Displaying output columnwise
• Number of columns displayed depends on the terminal size
• Sticky bits , special files like FIFO , character device , socket , block device.

ls's Issues

usage error with getopt

ls/main.c

Line 21 in 1ed9da3

* $ ./myls ­lS

hello, I am a postgraduate in china, so I 'am sorry for my poor English expression firstly.

You use getopt api function to parse command line input. As we known, getopt takes an element of argv starting with - as an option, so the usage here should be ./myls -lS instead of ./myls lS. The following usages are the same.

columns issue

ls/print.c

Line 74 in c5563bc

for(i = 0 ; i < n/n_r ; i++ ) {

n_r is the numbers of rows, so n/n_r is the numbers of columns. So there is a problem that we suppose n = 10 n_r = 3, so obviously n/n_r = 3. But the actual number of columns should be 4 instead of 3. I don't understand the meaning of the code here, can explain?

sizeof(char) instead of sizeof(char *)

ls/ls.c

Line 157 in c5563bc

temp_d[0] = (char *) malloc ( SIZE_P * sizeof( char *) );

temp_d is the char **, so it is a array with char * type. So temp_d[0] should be char *, it is a array to store char.

usage error with getopt

ls/main.c

Line 21 in 1ed9da3

* $ ./myls ­lS

hello, I am a postgraduate in china, so I 'am sorry for my poor English expression firstly.

You use getopt api function to parse command line input. As we known, getopt takes an element of argv starting with - as an option, so the usage here should be ./myls -lS instead of ./myls lS. The following usages are the same.