arrai-innovations / circleci-orbs Goto Github PK

Currently, all badges include the branch name. Some include the Python version. This makes it difficult to arrange on a project's readme.

We could find the following, reduced badge text more useful for the following services:

• CircleCI: TESTS
• Python/JS coverage: COVERAGE
• Flake8: FLAKE8
• ESLint: ESLINT

we should as a commit hook that checks if changed orbs are valid using circleci orb validate

Current pytest orb supports pipenv, but more and more repositories in my company are being migrated to poetry ( https://python-poetry.org/ ).
I could work on a PR to add support for poetry in the pytest orb, on top of the existing pipenv support.
Caller would be able to select between the 2 dependency managers, and pipenv would be of course kept as the default as to not break anything.
I actually already started this work, but I'm wondering if such PR would be welcome, or if it's something that maintainers would prefer to avoid (as it does make the job more complex).

Due to arrai-innovations/badass#996, there are many more flake8 plugins available to install. To make use of these plugins, we'd have to change the following in the flake8.yml orb:

• install flake8_requirements.txt (this file contains the flake8 requirement)
• use flake8 --append-config=.flake8errors to generate only errors
• use flake8 --append-config=.flake8warnings to generate only warnings

The eslint orb defaults to node v8, which is EOL. This causes errors since the latest eslint installed (v7.0.0) dropped v8 support: eslint/eslint#12700.

We should remove v8 and add v14. Then, update the default to the current, latest LTS release: v12.

It would be nice if we could have tests run on pull requests from forks. Circleci has a setting to not pass secrets to these instances. The rsync steps in utils would blow up without proper ssh keys / environment vars. We should:

• make all the steps in the utils orbs skip if DOCS_HOST is not set in the environment. this skip should not be considered a failure.
• bump the utils version in the other orbs (particularly, flake8).
• bump the utils/flake8 orbs in public repos' config.yml.