GithubHelp home page GithubHelp logo

Comments (6)

will-rowe avatar will-rowe commented on September 4, 2024 2

Sorry for the delay in getting back to you @Shaokang123 - I don't normally monitor this repo and the pipeline dev happens over at artic pipeline.

@bede is right - there is no global pipeline parameter for adjusting minimum read depth per reference base. I'm not sure of the reason to this but I guess it's because we mask out both low coverage bases with N, as well as using coverage during the variant filtering, so having one variable controlling these is a little misleading.

To decrease minimum read depth required per base, you need to adjust the artic_make_depth_mask command in the minion.py script - just add --depth 15. If you want to also change the minimum read depth for variant filtering, you will need to adjust what is happening in vcf_filter.py.

I think it would be useful to adjust the minimum read depth for the former case here, I'll make a PR to the pipeline repo. Hope this helps, let me know if it doesn't!

from artic-ncov2019.

nickloman avatar nickloman commented on September 4, 2024 2

I would be keen to see this as a configurable parameter to artic minion. However I would suggest people don't go lower than 20x! Partiularly as nanopolish will not call anything below 20x.

from artic-ncov2019.

laura-bankers avatar laura-bankers commented on September 4, 2024 2

Has there been any movement towards making min depth a configurable parameter to artic minion --medaka? Given all of the recent conversations in the public health community about the effects of minimum coverage depth for variant and consensus calling for SAR-CoV-2, it would be great if there was a more user friendly way to test how changes to workflow parameters (min depth in particular) influences our QC metrics and outputs from artic.

from artic-ncov2019.

Shaokang123 avatar Shaokang123 commented on September 4, 2024

May I ask if any one can help answer the question?

from artic-ncov2019.

bede avatar bede commented on September 4, 2024

At a glance, it looks like the following files will need editing

margin_cons.py
make_depth_mask.py
vcf_filter.py

from artic-ncov2019.

Shaokang123 avatar Shaokang123 commented on September 4, 2024

Great. Many thanks to all of you! Appreciate the help. @bede @will-rowe @nickloman

from artic-ncov2019.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.