artsy / eidolon Goto Github PK

this link will lead to a card just like "Conditions of Sale" has been outlined.

A slight adjustment3 (mostly use of animation) at the end of the bid flow/registration flow. Because users were blowing past the screen that both confirms that their bid was placed AND gives them their bidder details I am trying to space these two pieces of information out a bit more.
Current Screen

Suggested adjustments
http://cl.ly/image/280Q2G281j3G

Let me know if you have questions, trying to put together an animation so that the transition is more clear.

#90

new api for Artwork Artists lists either a collection of artists or a string saying a cultural maker.

It'd be better if we could write snapshots like this: expect(view) == snapshot("full")

I took a stab at this but it won't seem to let me call haveValidSnapshotwhich is a tad confusing.

import Nimble

struct Snapshot {
    let name: String

    init(name: String) {
        self.name = name
    }
}

func snapshot(name: String) -> Snapshot {
    return Snapshot(name: name)
}

func == <Snapshotable: Comparable> (lhs: Expectation<Snapshotable>, rhs: Snapshot) -> Bool {
    lhs.to( haveValidSnapshot(named: rhs.name) )
}

This was discussed in an artsy hangout, but I wanted to get it into something actionable, Our NetworkingAPI should:

• Make it easy to run offline
• Make it possible to run network requests synchronously
• Treat stubs as a first class citizen
• Allow tests to state only networking request X is allowed during this test run
• Allow iterating through all potential API requests at runtime for API sanity checks
• Keep track of current requests and don't support dupes

Think this is best done by having the request generation & the networking API client separate. A lot like how we have it in existing apps. Not assigning someone, but they should get ticked off as it happens, definitely better to do it earlier.

Just some barebones thing, something with a single passing test so we can get infrastructure up and running.

This happens occasionally on ici but is much easier to do on two-x-two-2014

    Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints) 
(
    "<NSLayoutConstraint:0x1782967b0 V:[UIImageView:0x1701f8900(56)]>",
    "<NSLayoutConstraint:0x178297020 H:[UIView:0x17819a750(184)]>",
    "<NSLayoutConstraint:0x17829ba30 H:[ARSerifLabel:0x12dd46640'Current bid: \U00a31,750'(304)]>",
    "<NSLayoutConstraint:0x178293f10 H:[Kiosk.ActionButton:0x12dd78d10'BID'(127)]>",
    "<NSLayoutConstraint:0x178485d20 H:[UIView:0x178197010(0)]>",
    "<NSLayoutConstraint:0x17829a6d0 UIImageView:0x1701f8900.width == UIImageView:0x1701f8900.height>",
    "<NSLayoutConstraint:0x17829a130 H:|-(0)-[UIImageView:0x1701f8900]   (Names: '|':UIView:0x178197010 )>",
    "<NSLayoutConstraint:0x17829a450 H:[UIImageView:0x1701f8900]-(28)-[UIView:0x17819a750](LTR)>",
    "<NSLayoutConstraint:0x17829bad0 H:[UIView:0x17819a750]-(33)-[ARSerifLabel:0x12dd46640'Current bid: \U00a31,750'](LTR)>",
    "<NSLayoutConstraint:0x178293a10 H:[ARSerifLabel:0x12dd46640'Current bid: \U00a31,750']-(33)-[ARSerifLabel:0x12dd798a0'1 bid placed'](LTR)>",
    "<NSLayoutConstraint:0x17829a360 ARSerifLabel:0x12dd798a0'1 bid placed'.right == Kiosk.ActionButton:0x12dd78d10'BID'.left - 33>",
    "<NSLayoutConstraint:0x178292f70 Kiosk.ActionButton:0x12dd78d10'BID'.trailing == UIView:0x178197010.trailing>"
)

The current bootstrapping does not work because a pod install (with current cocoapods version 0.34.0.rc2) gives a [!] Unable to find the file system source named: 'artsy'.
Any advice on how to workaround this issue or did i miss anything? Commenting out source 'artsy' gives a e.g. [!] Unable to find a specification for 'Artsy+UIColors (= 1.0.0)' depended upon by Podfile.

Thanks in advance

This is the OSS version of Garamond: http://www.georgduffner.at/ebgaramond/
This is the closest free version of Avant Garde: http://www.fontsquirrel.com/fonts/TeX-Gyre-Adventor

place bid > mobile number > enter email > ...check in the database ... = 1. User does not exist, enter registration flow 2. User does exist send them to login with artsy login details

instead of 4 : 41 : 02 it should -> 04 : 41 : 02

Whilst related to #3 we need to cover getting the enterprise certs set up for internal release, and for the makefile to have a one command deploy.

Also related to #2 in terms of daily.

http://cl.ly/image/0j2b2g2E2u0s

We should create a new artsy-oss-snapshots s3 bucket for things like this and Artsy+UIFonts./ Colours.

Not sure where the mistake is happening. I already made some changes to our logic to try to protect ourselves from some things, but somethig else is going wrong. Here is the result of repeatedly hitting the "8" button and loggint what self.bid should become:

cc @orta

Can't use TravisCI with Swift projects. Need to get our Jenkins up to date.

• master
• prs
• dailys

Just spotted these and then realised that these tests are acting on the global defaults.

Tests shouldnt ever be touching real defaults 👍

I put in 35000, pressing the delete button doesn't do anything. Same as when you just put in one number '7' for example.

So all of our snapshot tests basically produce just one image, even if multiple tests in the suite generate multiple images; they're all generated with the same filename.

Probably a problem with https://github.com/AshFurrow/Nimble-Snapshots

New language for grey text "A credit card is required to verify your identity and bid in this auction."

Will depend on Moya/Moya#48.

@katarinabatina the mocks didn't have any artworks with no bids. What's your preference? We'll need to know for both the grid view and tabular view.

The background colour of the button (black or purple, depending on its state) is slightly visible behind the white border.

see ConfirmYourBidArtsyLoginViewController.swift line 34

(will update issue in a moment)

Genuinely have no idea why some view controllers occasionally do not render. roughly 1/6 runs. Generally different each time.

Install Quick for testing and FBSnapshotTestCase for snapshot testing.

After this, we can do #8.

Problem in the Makefile? Got this error after entering in all the keys.

if [ ! -f ~/.cocoapods/artsy ]; then
/bin/sh: -c: line 1: syntax error: unexpected end of file
make: *** [bootstrap] Error 2

Say you enter some bid, which is validated against the current minimumNextBidCents, and then you enter the login/signup flow while someone else finalizes a bid, rendering your bid no longer valid (as opposed to a higher maximum bid having already been placed, which results in a "you've been outbid" message). Does any other client handle this? is this a legit concern?