Crash/Kick with Slime Blocks and Iron Golem morph (caused by exponential gravity) about changeling

[asanetargoss]

As per mchorse#206 , this is fine, waiting on McHorse to decide if survival-related code contributions should target Changeling only (and machinima-related code Metamorph only); would hopefully make our git sorcery a bit simpler and changes would make their way to the other mod eventually.

[James103]

I have tested this, a terminal velocity of approximately 100 m/s is reached while morphed as an Iron Golem, compared to 78.4 m/s for others. Jump height is about 1.1 m. No crash/kick is made.

[James103]

I've talked with @mchorse about this, and he said that my second idea would be a perfect solution to this, with my third solution being a possible alternative.

The code for the second idea would be as follows:

if (target.motionY < 5)
{
    target.motionY *= (1.1 - target.motionY / 50.0);
}

Which would replace:

Changeling/src/main/java/mchorse/vanilla_pack/morphs/IronGolemMorph.java

Line 29 in 3208f20

target.motionY *= 1.3;

As for my third idea, since a gravity of 0.10 meters per tick squared supposedly still allows jumping 1 meter despite a 25% increase over standard gravity (0.08 meters per tick squared), either the gravity should be increased by 0.02 (target.motionY -= 0.02;) or the gravity multiplied by 1.25.

I'm still waiting for @asanetargoss on what would be the best possible solution to this.

[asanetargoss]

A new version of Changeling has been released on GitHub with the fix:

https://github.com/asanetargoss/Changeling/releases

I decided to postpone important maintenance, because I want to get a build up before McHorse's 1.12-only version of McLib gets released, and the possible confusion which could result from that.