asdfdotdev / utm.codes Goto Github PK

I checked to force alphanumeric only in settings and this converted spaces to hyphens. I actually like this behavior, but it's not what people expect by the term alphanumeric.

Personally, I prefer to use underscores as spaces and hyphens as separators like so:

promotion_a-2019_02

promotion_a-2019_03

promotion_b-2019_02

promotion_b-2019_03

This way it is easier to write regular expressions for the purpose of filtering semantically distinct portions of information that were crammed in the same utm field. I am not sure how this could be facilitated by your plugin, though as it seems semantics would need to be determined by the user... Maybe you could provide an option to transform spaces to underscores for a start (except the spaces before or after a hyphen typed by the user). Then the user would just need to be instructed to type naturally and use hyphens to separate pieces of information within fields and that would address everything, really. What do you think?

Great plugin idea, by the way!

It'd be nice to be able to capture notes with a link to provide context/reference. This could include the update/tweet/email the link is used in, the details about the referrer using the link, etc.

The test classes are nice, but nobody wants to run them manually. 😄

Displaying all the utm parameters in this location seems pointless as they are already present in the other columns where they are much more legible. It also blows up the height of rows and looks noisy.

Adding the ability for administrators to configure fixed options for source and medium would be helpful in creating links more quickly and consistently.

Core code is already compatible but README.txt should be updated to state 5.0 compatibility and Travis build should test against 5.0 explicitly (nightly is 5.1 alpha as of this issue).

Let's use the following composer packages and clean things up and while we're at it also include phpunit to make things easier.

• https://packagist.org/packages/squizlabs/php_codesniffer
• https://packagist.org/packages/wp-coding-standards/wpcs
• https://packagist.org/packages/phpcompatibility/php-compatibility
• https://packagist.org/packages/dealerdirect/phpcodesniffer-composer-installer
• https://packagist.org/packages/phpunit/phpunit

Describe the bug
TestUtmDotCodesUnit::test_post_type test fails on featured image label. Currently there isn't a label for featured image set in utm.codes, however, this issue can be resolved by adding one in create_post_type().

To Reproduce

Run unit tests.

Expected behavior

Expected and actual labels should match, there is a mixed case on image vs Image.

Site Information

• utm.codes version: v1.6.3
• WordPress version: v5.4-beta1-47294
• PHP version: v7.4.2
• MySQL version: MariaDB v10.4.11

What is the difference between saving a marketing link and publishing it? I don't see how it could make a difference given that UTM functionality operates outside of WP. Also, when using the QuickEdit function, the panel displayed appears broken / not useful, e.g. none of the fields are populated even if data is present, utm fields are missing from the panel and instead there are fields like publishing date and password protection which make no sense for managing links.

Documentation for:

• Setup
• Creating links
• Filter/Search links
• Settings config
• etc.

Two uses of the custom shortner object filter (utmdc_shorten_object) are missing the interface include resulting in an error when a custom shortener is in use.

This include uses in meta_box_contents() and render_settings_options().

Add the interface include to resolve this.

Not everybody uses Bitly and Rebrandly gives more in their free tier.

It would be useful to have the ability to specify which domain to use for the url shortening services (ie default or custom).

I manually modified line 77 of utm-dot-codes/classes/shorten/class-rebrandly.php in order to use my custom domain name for short urls instead of the default rebrand.ly domain.
'body' => wp_json_encode( ['domain'=>['fullName'=>'mycustomshortenerdomain'], 'destination' => $data['utmdclink_url'] . $query_string ] ),

Details here.

Would make utm.codes friendlier if we added filter API support to allow additional programmatic changes to link formats when saving links.

5.4 should be 5.6 in the PHP compatibility test command.

Adding the option to programmatically alter the social sources available with an API filter would be nice.

Something simple like https://github.com/zenorocha/clipboard.js/ could be used and would improve usability as users no longer need to use the keyboard to copy a link to the clipboard.

It's silly this was omitted.

Describe the bug

Quick Edit links are missing from all post types. Based on the change log notes from v1.5.0, I'm guessing the intended behavior is for them to be removed only within the utm.codes post type.

To Reproduce

Steps to reproduce the behavior:

1. Go to the admin
2. Click on Posts > All Posts
3. Hover any existing post
4. See that Quick Edit is missing

Expected behavior

Quick Edit should be visible as is the default expected functionality outside of the scope of this plugin's post types.

Screenshots

Site Information

• utm.codes version: 1.6.1
• WordPress version: 5.2.3
• PHP version: 7.3.6
• MySQL version: 10.3.15-MariaDB

It seems clear that once a user has a long history of utm links created with the plugin, usually only a few are currently relevant to the user, such as the ones pertaining to an upcoming promotion.

This being so, the plugin should remember the active filter settings when navigating away and back to the marketing links page. If no filters were set, perhaps the default should be to show the last 25 links created by the currently logged-in user.

An additional dropdown on the marketing links page for filtering by author would allow the user to deviate from the default filtering and have a look at utm links created by co-workers.

Add option to enforce utm code value formats:

• Remove non-alphanumeric characters
• Force lowercase
• Replace spaces with dashes

Per this post the README.txt should be friendlier and include an explicit mention of/link to build code here in the developer repo.

This should be included in the switch to webpack which is currently in the development branch.