GithubHelp home page GithubHelp logo

Duplicates about mdanki HOT 10 OPEN

ashlinchak avatar ashlinchak commented on May 27, 2024 4
Duplicates

from mdanki.

Comments (10)

ewnd9 avatar ewnd9 commented on May 27, 2024 2

Hey all, sorry for the long time. I've released [email protected] with the patch from @amorriscode 👍

from mdanki.

ashlinchak avatar ashlinchak commented on May 27, 2024 1

Thanks, @amorriscode, and @DHNishi for the investigation and the PR. I'll update the dependency when the PR'll be merged to anki-apkg-export

from mdanki.

amorriscode avatar amorriscode commented on May 27, 2024 1

@ashlinchak I made a PR. 😄

from mdanki.

DHNishi avatar DHNishi commented on May 27, 2024

This appears to be an issue in the underlying library. repeat-space/anki-apkg-export#37 calls attention to it. Essentially, https://github.com/repeat-space/anki-apkg-export/blob/master/src/exporter.js#L99 appears to show it using the timestamp of generation to create the card ID. I think if it switched to using something like a hash of the deckName and the card front, you could probably avoid the duplicate problem.

from mdanki.

amorriscode avatar amorriscode commented on May 27, 2024

@DHNishi thanks for the investigation. I made a PR over there. We'll see if it gets in!

from mdanki.

amorriscode avatar amorriscode commented on May 27, 2024

So I realized now that the update of anki-apkg-export doesn't quite solve the problem. The issue being that existing decks don't get loaded and updated. They are just completely regenerated.

from mdanki.

ashlinchak avatar ashlinchak commented on May 27, 2024

Yeah, just checked it :) I believe having this is not enough as those variables are generated based on the topDeckId which is generated based on Date.now() anyway.

from mdanki.

amorriscode avatar amorriscode commented on May 27, 2024

🤦‍♂ Sorry about that. I suppose the topDeckId should be based off of the deck name itself?

from mdanki.

amorriscode avatar amorriscode commented on May 27, 2024

Made a new PR based on some of our ideas. Tested it with mdanki this time.

Not sure if it handles nested decks; that will require more research but it's a start.

from mdanki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.