ashqal / chromelikeswipelayout Goto Github PK

View Code? Open in Web Editor NEW

644.0 644.0 71.0 685 KB

Pull down, and execute more action!

Java 100.00%

chromelikeswipelayout's People

Contributors

Stargazers

Watchers

chromelikeswipelayout's Issues

Nested RecyclerView fails to scroll

Given the following layout RecyclerView fails to scroll up:

FrameLayout
    com.asha.ChromeLikeSwipeLayout
        android.support.percent.PercentRelativeLayout
            android.support.v7.widget.RecyclerView
            ...

I think it's due to the fact you only take into account the first child of ChromeLikeSwipeLayout to check if it's scrollable or not. This kind of situation must be taken into account since having a layout with a nested RecylcerView it's quite a common scenario.

Maybe look into using jitpack?

https://jitpack.io/

Deploying a new version is as easy as doing a github release :) So you don't have to run a deploy task after every code change

Attribute "radius" has already been defined

http://stackoverflow.com/questions/30270016/attribute-raduis-has-already-been-defined

Basically if you use another library (in this case CirclePageIndicator) you will run into issues on compile. If I prefix the variables with swipe_ (ie. swipe_radius) and open a PR can you merge it in? Thanks

onNestedPreFling throws error for projects that have minSDK < 21

So I was testing on an older phone (api 15) and used the library and unfortunately it crashes on fling with the following stacktrace:

02-08 17:36:44.324 20427-20427 E/AndroidRuntime: FATAL EXCEPTION: main
                                                                      Process: com.adhoclabs.burner, PID: 20427
                                                                      java.lang.NoSuchMethodError: android.view.ViewGroup.onNestedPreFling
                                                                          at com.asha.ChromeLikeSwipeLayout.onNestedPreFling(ChromeLikeSwipeLayout.java:578)
                                                                          at android.support.v4.view.ViewParentCompat$ViewParentCompatStubImpl.onNestedPreFling(ViewParentCompat.java:124)
                                                                          at android.support.v4.view.ViewParentCompat.onNestedPreFling(ViewParentCompat.java:404)
                                                                          at android.support.v4.view.NestedScrollingChildHelper.dispatchNestedPreFling(NestedScrollingChildHelper.java:252)
                                                                          at android.support.v7.widget.RecyclerView.dispatchNestedPreFling(RecyclerView.java:8675)
                                                                          at android.support.v7.widget.RecyclerView.fling(RecyclerView.java:1797)
                                                                          at android.support.v7.widget.RecyclerView.onTouchEvent(RecyclerView.java:2437)
                                                                          at android.view.View.dispatchTouchEvent(View.java:7782)
                                                                          at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2316)
                                                                          at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2013)

Looks like we might need to do a version check before call super. for onNestedFling and onNestedPreFling.

ashqal / chromelikeswipelayout Goto Github PK

chromelikeswipelayout's People

Contributors

Stargazers

Watchers

Forkers

chromelikeswipelayout's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs