Comments (10)
Yes that seems reasonable, I'll try and open a PR shortly to do all this.
from astropy-iers-data.
Yes, the goal is to auto release as soon as the data files are updated - we can always adjust the frequency of the auto updates if this is too frequent but the idea is that PyPI should have recent versions of the files. Most PRs will just be the auto updates, so this should be ok, unless they are to change/fix something in which case we need to check the CI anyway.
from astropy-iers-data.
unless they are to change/fix something in which case we need to check the CI anyway
Okay, but the workflow currently does not skip tag and publish even for PR. Will that mess things up?
from astropy-iers-data.
And what if something is merged into main
but has nothing to do with actual IERS update?
from astropy-iers-data.
Tag only happens on main pushes (
) - and yes we do want to do it even on regular PRs I think as those might be fixing something with the build for instance. There's really no harm in releasing on every main commit, as you can see from recent activity there really isn't much aside from the auto updates.from astropy-iers-data.
Well... I almost accidentally triggered a release by adding Zenodo badge to main
. Luckily I added a [ci skip]
last minute. But I might not remember every time!
from astropy-iers-data.
I feel like this should just be a workflow_dispatch
because you have to manually do a GitHub Release anyway to trigger Zenodo upload.
from astropy-iers-data.
Will reply to this soon!
from astropy-iers-data.
One of my goals with this package was to keep it as low maintenance as possible and to try and have things as automated as possible.
Now that things are running smoothly, I was actually planning to get rid of the automated update PRs and instead automatically commit to master if the CI passes - this is actually better than the current PRs for which the CI doesn't run by default. With this in place releases would be completely automated and I could have the workflow open an issue or PR if the workflow starts failing for any reason.
Changing to workflow dispatch goes the opposite direction of then having someone have to do multiple manual steps every week. I would prefer to automate the creation of GitHub releases if possible, and if not possible (eg if it doesn't trigger the Zenodo hook) then I don't think Zenodo releases are a sufficient motivation for switching a fully automated workflow to a weekly manual workflow so I would prefer to drop Zenodo.
from astropy-iers-data.
Can we at least have the workflow not to publish unless it is that one IERS update bot push that matters? It is fine to want full automation but also need to prevent unnecessary releases. Thanks!
from astropy-iers-data.
Related Issues (13)
- List of mirror URLs for IERS download HOT 28
- Improve auto-update workflow HOT 2
- Zenodo DOI HOT 2
- TST: Point to canonical astropy HOT 2
- Move update_data.sh to scripts folder
- Where is this package on conda? HOT 3
- Automate GitHub release and Zenodo HOT 2
- Change log does not indicate data update because it is not done as PRs HOT 3
- Tags are inconsistent with PyPI versions HOT 8
- PyPI wants us to use trusted publishing
- Dependencies cycle with Astropy to run tests HOT 3
- Switch to Hatch HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from astropy-iers-data.