astropy / astropy-iers-data

IERS data maintained by @astrofrog and astropy.utils.iers maintainers

IERS Earth Rotation and Leap Second tables for the astropy core package

Note: This package is not currently meant to be used directly by users, and only meant to be used from the core astropy package.

https://docs.astropy.org/en/latest/utils/iers.html

License

This project is Copyright (c) Astropy Developers and licensed under the terms of the BSD 3-Clause license. This package is based upon the OpenAstronomy packaging guide which is licensed under the BSD 3-clause licence. See the licenses folder for more information.

Contributing

We love contributions! astropy-iers-data is open source, built on open source, and we'd love to have you hang out in our community.

Imposter syndrome disclaimer: We want your help. No, really.

There may be a little voice inside your head that is telling you that you're not ready to be an open source contributor; that your skills aren't nearly good enough to contribute. What could you possibly offer a project like this one?

We assure you - the little voice in your head is wrong. If you can write code at all, you can contribute code to open source. Contributing to open source projects is a fantastic way to advance one's coding skills. Writing perfect code isn't the measure of a good developer (that would disqualify all of us!); it's trying to create something, making mistakes, and learning from those mistakes. That's how we all improve, and we are happy to help others learn.

Being an open source contributor doesn't just mean writing code, either. You can help out by writing documentation, tests, or even giving feedback about the project (and yes - that includes giving feedback about the contribution process). Some of these contributions may be the most valuable to the project as a whole, because you're coming to the project with fresh eyes, so you can see the errors and assumptions that seasoned contributors have glossed over.

Note: This disclaimer was originally written by Adrienne Lowe for a PyCon talk, and was adapted by astropy-iers-data based on its use in the README file for the MetPy project.

astropy-iers-data's Issues

Move update_data.sh to scripts folder

Looks weird in the root dir. Workflows that call it also need to be updated.

Switch to Hatch

As the build system

TST: Point to canonical astropy

Just a reminder issue for this:

https://github.com/astropy/astropy-iers-data/blob/d29c3b651f0e8ce8cf286982fca08860f6cfced7/tox.ini#L10C4-L11

Also probably need to test both stable and dev astropy? Or is that overkill?

Where is this package on conda?

You mentioned grabbing this from conda over at astropy (astropy/astropy#14819) but where is the feedstock? How do we make sure the conda version won't fall behind? If no one diligently merge the conda feedstock updates, it is going to fall behind.

PyPI wants us to use trusted publishing

https://docs.pypi.org/trusted-publishers

List of mirror URLs for IERS download

Transferred from astropy/astropy

Both of the USNO hosts (maia.usno.navy.mil, toshi.nofs.navy.mil) for retrieving the IERS Bulletin A dataset are flaky. Instead of a primary URL specified by the configuration setting utils.iers.iers_auto_url and mirror URL by utils.iers.iers_auto_url_mirror, I suggest a single list of URLs.

Here is what I propose for backward compatibility:

• Understand both iers_auto_url and iers_auto_url_mirror to be either a string or a list of strings.
• Construct the list of URLs to try by concatenating all of the URLs from iers_auto_url and iers_auto_url_mirror and removing duplicates.
• Deprecate the iers_auto_url_mirror configuration setting for removal in a future release.

Here is a possible default URL list:

• http://maia.usno.navy.mil/ser7/finals2000A.all
• http://toshi.nofs.navy.mil/ser7/finals2000A.all
• ftp://cddis.gsfc.nasa.gov/pub/products/iers/finals2000A.all
• https://datacenter.iers.org/data/9/finals2000A.all

Zenodo DOI

Do we need to set up Zenodo webhook to capture the releases? We do that for almost everything else.

tag/publish workflows should not run for every push?

https://github.com/astropy/astropy-iers-data/blob/main/.github/workflows/main.yml

Is this really meant to run every time someone push to main and PR branch? Sounds excessive.

Improve auto-update workflow

Currently when the auto-update PRs are opened, because they are opened from @github-actions, the CI does not run. We need to manually close and re-open the PR. We could get around this by using a personal access token instead of the usual GITHUB_TOKEN token but these expire at most after a year so need to be updated manually. We should think about how we could improve this workflow.

Tags are inconsistent with PyPI versions

v0.2023.07.31.00.32.45 in https://github.com/astropy/astropy-iers-data/tags is released as 0.2023.7.31.0.32.45 on https://pypi.org/project/astropy-iers-data/#history . Kinda confusing.

Dependencies cycle with Astropy to run tests

I've faced with this issue during preparing this project for Guix when update Astropy to 6.0.0 requires it as external package.

According to tox.ini requires astropy itself to run tests:

This project:

astropy-iers-data/tox.ini

Lines 9 to 18 in 1198afe

	deps =
	git+https://github.com/astropy/astropy
	extras =
	test
	commands =
	pip freeze
	pytest --pyargs astropy.coordinates -m "not hypothesis" {posargs}
	pytest --pyargs astropy.time -m "not hypothesis" {posargs}
	pytest --pyargs astropy.utils.iers -m "not hypothesis" {posargs}

Astropy project:
https://github.com/astropy/astropy/blob/9ce2087bd81f9502c4fdb87168d1cccd1aee4f53/pyproject.toml#L41-L47

Is there any other way to test the project without astropy?

Thanks.
Oleg

Automate GitHub release and Zenodo

Once #13 is merged I need to try and see if we can automate the GitHub release + Zenodo step.

Change log does not indicate data update because it is not done as PRs

See https://github.com/astropy/astropy-iers-data/releases/tag/v0.2023.07.06.21.08.44

Would be more useful if the change log says which files changed but it only auto generate from PRs and file updates are done directly to main.

🤷