asutton / beaker-cc Goto Github PK

Invalid type identifiers in field declarations produce free(): invalid pointer error.

Recent changes that introduced the use of the C++ standard library function std::to_string() cause compiler errors when building Beaker with GCC on platforms where the system C library is newlib (e.g. Cygwin). This is a documented defect of libstdc++ (see asutton/origin#2) that has only been fixed recently in GCC 6.0, which is still under development.

Possible solutions include the workaround that is currently used in Origin, using std::ostringstream, or C++ Format.

The program below segfaults (stack overflow) when generating the LLVM type.

struct S { s : S&; }

The generator needs to track which types have been defined instead of blindly recursing.

@asutton @thehexia: The current implementation of the code generation routines for the && and || operators in beaker/generator.cpp use the llvm::IRBuilder::CreateAnd() and llvm::IRBuilder::CreateOr() member functions, which produce instructions for the bitwise AND and OR operations, respectively—not the logical AND and OR (as I assume was the intention).

From llvm/IR/IRBuilder.h:

  Value *CreateAnd(Value *LHS, Value *RHS, const Twine &Name = "") {
    if (Constant *RC = dyn_cast<Constant>(RHS)) {
      if (isa<ConstantInt>(RC) && cast<ConstantInt>(RC)->isAllOnesValue())
        return LHS;  // LHS & -1 -> LHS
      if (Constant *LC = dyn_cast<Constant>(LHS))
        return Insert(Folder.CreateAnd(LC, RC), Name);
    }
    return Insert(BinaryOperator::CreateAnd(LHS, RHS), Name);
  }

  Value *CreateOr(Value *LHS, Value *RHS, const Twine &Name = "") {
    if (Constant *RC = dyn_cast<Constant>(RHS)) {
      if (RC->isNullValue())
        return LHS;  // LHS | 0 -> LHS
      if (Constant *LC = dyn_cast<Constant>(LHS))
        return Insert(Folder.CreateOr(LC, RC), Name);
    }
    return Insert(BinaryOperator::CreateOr(LHS, RHS), Name);
  }

FYI, I verified this myself using a test program—llvm::IRBuilder::CreateAnd() and llvm::IRBuilder::CreateOr() produce the 'and' and 'or' instructions, respectively.