ataradov / open-5012h Goto Github PK

here a couple of issues I found while using the device:

• the menu button does not open a menu (the readme mentions this is where I can set the 1x/10x probe)
• pressing F2 freezes the device (the screen does not update anymore and other button presses have no effect)
• in calibration mode I am able to set the zero value, but pressing on the trigger up/down does not seem to change the corresponding calibration value in the delta, scale, and offset mode (at least nothing visible changes)

let me know if I should open separate issues for each point.
note that I did not look at the source code, but maybe you have a quick answer before I do that.
else I quite like your firmware. thanks for all the work.

Played using a 100 KHz waveform and changing the frequency or the amplitude don't seem to affect the measurements on the right side of the bar. Is it possible to add a frequency measurement

?

Again, unsure what combination of keys are used but scope freezes and the only cure is a power cycle.

the very first time I flashed the firmware, the LCD worked and showed the oscilloscope screen.
the second time I powered the device (and further on), the LCD is only white, at the maximum brightness.
re-flashing the firmware, even after a chip erase, did not fix the issue.
I tried to change the rectangle color and reduce the brightness in lcd_init, but this did not change anything.
I guess there is something missing during the initialization, but I am not familiar with the ST7789.
Do you have any glue what the issue could be?

edit: the firmware seems to be running fine else (at least is is not stuck, and periodically calls lcd_data_write)

Occasionally I get a timer overflow error on the screen and the only cure is a power cycle. I am unsure what combination of keys causes it but I do know it is a combination of keys used

My friend bought one of the little scope and flashed the firmware but got Flash error on boot up.
Looking at code, it looks like the flash.c has flash ID checked for Windbond part.
GD 25Q64 has different ID, hence flash error.
Can you please add this patch in?

diff --git a/scope.c b/scope.c
index 4672a78..560394c 100644
--- a/scope.c
+++ b/scope.c
@@ -741,6 +741,8 @@ static void change_vertical_scale(int delta)
config.vertical_mult = config.calib_vs_mult[config.vertical_scale];
config.vertical_position_mv = config.vertical_position * vs_px_value[config.vertical_scale];

• config.trigger_level_mv = config.trigger_level * vs_px_value[config.vertical_scale];
• capture_set_vertical_parameters();
  capture_set_trigger_level(config.trigger_level_mv);
  draw_vertical_scale();

Thanks.