atikhono / defaultreviewers Goto Github PK

Trying to use the plugin and i'm getting error/warning on the log related to plugin writing settings.
Error is a SQL index violation error for plugin settings insert statement.

It appears that this line is causing the error:
pluginSettingsFactory.createSettingsForKey(PLUGIN_KEY).put(pluginSettingsId, newSha);

PR i'm trying this on has multiple commits, if that makes a difference. I also created and deleted PR from this branch multiple times. First few attempts plugin was disabled.
BitBucket Server version 5.7.0

Error log entry:

o.h.e.jdbc.spi.SqlExceptionHelper Unique index or primary key violation: "UQ_PLUG_SETTING_NS_KEY_INDEX_4 ON PUBLIC.PLUGIN_SETTING(KEY_NAME, NAMESPACE) VALUES ( /* key:690 */ 'com.parallels.bitbucket.plugins.defaultreviewers', '112.275', null, null)"; SQL statement:
insert into plugin_setting (key_name, namespace, key_value, id) values (?, ?, ?, ?) [23505-176]

Arm_xml/ owners=a.nelzin

Arm_xml - this is a directory
a.nelzin - this is username of bitbucket user

We have a large code base and numerous developers will be associated with each area.

When the plugin runs it creates a new Comment/Activity on the PR for each user that has been added. This can produce a large number of entries in the PR overview that distracts from the user supplied comments.

The PR update api may be more appropriate for bulk adding reviewers.
https://developer.atlassian.com/static/javadoc/bitbucket-server/4.4.1/api/reference/com/atlassian/bitbucket/pull/PullRequestUpdateRequest.Builder.html

Hello, do you plan to fully support Data Center?

We recently began testing your plugin, which appeared to install well but then did not function as expected.

After realising that the bitbucket server version we were running wasn't in the supported version list, we upgraded to v5.8.0 (supported).

Unfortunately, we are now in a situation where the default reviewers plugin no longer appears under Repository Settings -> Workflow (Hooks) as it did in the prior (unsupported) bitbucket version.

A response would be appreciated, as we'd very much like to use the plugin - it provides precisely what's needed for our particular repository setup.

When a user is added to the PR as a Reviewer it would be helpful if there was a comment that state the reason the user had been added.

I experimented with adding a comment at the time the user was added but it resulted in a potential swamp of comments.
e.g.

Ideally the files associated with the change would be aggregated into one comment or one comment per user and then added so that the PR is not overly cluttered.

Добрый день, Анна, извините вероятно на английском я неправильно сформулировал свой вопрос. Я установил и включил ваш плагин на репозитории. В корне этого репозитория создал файл .gitattributes, так же в корне репозитория есть папка Arm_xml, именно для этой папки мне нужно чтобы при пул реквесте затрагивающем эту папку, добавлялся ревьер по умолчанию a.nelzin

The DefaultReviewersHook is triggered for each page refresh in the Bitbucket Web UI even if there has not been any changes made to the PR.

With the DEBUG logging turned on:
curl -u admin:admin -v -X PUT -d "" -H "Content-Type: application/json" http://localhost:7990/bitbucket/rest/api/latest/logs/logger/com.parallels.bitbucket.plugins.defaultreviewers/debug

I see multiple entries in the atlassian-bitbucket.log that shows that the plugin is using git to check each file associated with the PR.

This process will add significant load to the Bitbucket server when large merge PRs are created.

Would it be possible to evaluate the cause of the event and avoid processing the PR if no updates have been made to the associated files.

Currently this plugin cannot be enabled on a 5.0 Bitbucket installation. It would be great if this was possible.