atlassian-archive / landkid Goto Github PK

Would be nice to display any non-sensitive config options in api/meta.

Knowing which repo an instance points at, which options are turned on, etc.

We've hit this situation a few times now, and the root cause was found today.

When we are moving a build from the queue to running, we lock landkid (different to pausing) so that other calls to next() wont be able to drop/overwrite builds.

Unfortunately, if any requests whilst we are creating the landkid build fail (i.e the one that creates the build), we don't currently handle that case, the build is dropped and the server remains locked.

The specific cause we found was if someone tries to land a build that was from before landkid was introduced. Since no landkid builds exist in the pipelines.yml, the build cant start and the request throws.

Some simple error handling around this would make a lot of sense...

I will consider Landkid ready for a 1.0.0 release once the following items are addressed:

• Flowtypes are all fixed up
• Abstractions are all at the appropriate level in the adaptors
• Tests and setup and better abstracted to make extending easier
• Github support is added
• Travis support is added
• We have a better way of end to end testing (small sample repo with a defined set of manual tests for example)
• We have a better dev loop (no hardcoded keys to change, etc)

There were some terrible mistakes/shortcuts taken to get this working that I now realise are going to make adding new adaptors much harder than it should have been.

We need to strongly define the exact data models we expect and make sure that the adaptors only call endpoints and translate to those forms and that all business logic lives in the runner.

Have a way to have a 'merge once green'

Likely behaviour, have a queue of builds to add to the general queue once they go green.

Queues of queues!

Alternatively, add it to the queue, but every time you want to take anything off the queueueueue it is skipped if it is not finished, and punted from the q if it fails.

We're going to need to make landkid more private by default.

• Hiding running builds
• Hide queue tab (or at least it's content)
• Hide history tab (at at least it's content)

Super simple fix, just add the paused check in runner.ts where we move from waiting to queued.

Let's do it with the major release.

Right now if you have a build on master which has side effects (releasing/publishing packages) that needs to push back to master, Landkid introduces a race condition where the Landkid build can finish and push to master before the master build has completed.

Ideally people wouldn't be publishing in master (and we should provide a step for publishing as part of Landkid as mentioned previously) but we should handle that gracefully if they do.

My PR failed to merge and not until 4 days later I realised. Landkid should have a way to notify authors if their PR fails -- preferably integration with popular chat apps.

I know there's a WIP section in the README about this. Are there any plans to complete that section?
If not, could you guide me how one can go about running this locally against a bitbucket server instance?

hello Landkid Contributors,

I am setting up Landkid in the VM which is publicly accessible. I have done below mentioned configurations so far.

• Configured local Redis instance and using Sqlite DB.
• I have setup Bitbucket Oauth credentials with all the permissions, set call back URL and added secrets and key into config.js file.
• I have set baseURL to the public IP of the VM and the port along with repo owner, name and UUID in config.js.
• For the landkidAdmins, I have tried Bitbucket username, aaid, uuid also.

After setting up all these parameters, I did "npm run build" and "npm start". I can browse the landkid app in browser and when I click on "Go" button, it goes to Bitbucket for authorization and getting authorized. But on the current-status page, I see below mentioned message.

I have created Pull Request in the repo, with comment as "land". But still I am not seeing any changes in Landkid UI. Can you please guide me.

The flowtypes were quite badly broken during the massive refactor.

These will need to be fixed and then enforced in the pre-push hook.

• Flow types fixed
• Typechecking added to prepush hook

This will probably require #6 to be completed