Comments (9)
I'm not a rubyist so my fix is to remove support for this
from heaven.
My change above wasn't enough as it breaks the string interpolation
from heaven.
We use the fabric provider on a daily basis, including the ENV configuration. Not sure why you're having a problem with it.
from heaven.
@brentc I no longer have the full traceback, but this specifically is due to local_log_file:
unless last_child.success?
fail StandardError "Task failed: #{cmds.join(" ")}"
end
In all fairness this might be a false positive. I'm sort of just guessing at how to actually get heaven working by digging into code (the docs are pretty far from even being usable).
from heaven.
Seems lots of the error handling code is problematic, this also straight up fails with another error:
undefined method `StandardError' for #<Heaven::Provider::Fabric:0x007f8468a46ef8>
from heaven.
I think that line probably needs a comma. Unfortunately I don't use fabric in my projects. Do you need a hand working through the stacktrace or can you send a PR with your changes? I'd rather not remove the env var override if possible.
from heaven.
@atmos The other examples suggest a different format for commands (i.e. the command split according to shell interp. vs a string of the command). It's possible I'm misinterpreting things, but I think the actual issue here is likely the logger itself.
For now I'm reverting my changes and will dig through the stderr logs that get posted to gist to work through "what do we need to do to make it actually work"
from heaven.
Ah, it looks like all the other usages of execute_and_log
pass a list [..., ...]
structure, but line 38 of the fabric provider is passing in a string:
log "Executing fabric: #{deploy_command}"
execute_and_log(deploy_command)
As I implemented the provider, this is my mistake. It would appear this only causes a problem when there's an actual problem running the fabric command (and is being thrown to the logger) since, as I noted above, we use this code to deploy several times a day.
from heaven.
I suspect changing the line to
execute_and_log([deploy_command])
Would resolve the issue with the logger.
from heaven.
Related Issues (20)
- Update provider libraries to download tarball vs cloning a git repository HOT 8
- Possible to use a different version of Ruby in bundler_capistrano? HOT 3
- Cannot Deploy to Heroku using web UI HOT 2
- Why DEPLOYMENT_PRIVATE_KEY don't take effect? HOT 2
- Remove formation size from app.json
- github oauth issue
- Heroku deploy button not working HOT 4
- 404 error page on "/resque" (after OAuth'ing with GitHub) HOT 3
- Is it possible to limit which repositories can be deployed? HOT 6
- Archive downloads break deployments HOT 2
- Documentation question HOT 3
- Heaven installation HOT 2
- Elastic Beanstalk doesn't work! HOT 3
- Default value for GITHUB_TEAM_ID
- How to deploy private repository HOT 8
- A question on `github_authenticate` HOT 3
- How to host heaven on ubuntu14.04 instead of heroku HOT 8
- New payload for deployment statuses HOT 4
- DEPLOYMENT_PRIVATE_KEY doesn't get used HOT 4
- Heroku API Deprecation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heaven.