GithubHelp home page GithubHelp logo

moactionplugin's People

Contributors

attickdoor avatar goaaats avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

moactionplugin's Issues

Settings doesnt save

Hello, just wanted to ask: all my setting were recently removed. If I create new settings (then save them) they are removed after restarting of the game. Does anyone know how to fix it?

Request for the “enable all” button

Would it be possible to split that into 2 different buttons, one for damage abilities and one for everything else? I like using support as MO but damage abilities get finicky and frequently just result in me having to move the mouse off a party member.

Field mouseover not working

Tried clean install of the plugin, along with deleting anything relating to the plugin and it still does not work.

UI MO works just fine but field MO is having issues, not sure if it needs an update or not.

Ground-target actions with Mouse Location MOAction can't target non-combat NPCs via <t>

Edited for typos

For example, Shukuchi is not able to target the Eulmore Delivery Moogle when mouse location stacks are enabled, but is when there is no stack for it and the player uses /ac Shukuchi <t> with the moogle selected. The chat action continues to work correctly if a stack exists that has only the "Target" target option, but if one exists that has the "Mouse location" target option, then /ac Shukuchi <t> goes to the mouse location. This issue does not occur if the target is a player or combat npc.

Repro steps:

  1. Remove any preexisting stack for Shukuchi
  2. In Eulmore, target the Delivery Moogle and move into range of it for Shukuchi
  3. Type in your chat box /ac Shukuchi <t>
  4. Observe that the Shukuchi executes successfully and you are now under the moogle

  1. Move away from the Moogle so that Shukuchi's behavior will be easier to observe
  2. Add a stack for Shukuchi using the "Target" target option.
  3. Save the stack.
  4. Attempt to use Shukuchi via the chat box again
  5. Observe that it still works
  6. Attempt to use Shukuchi via a hotbar
  7. Observe that, rather than executing Shukuchi, your character does nothing and the ground-targeting indicator appears under the mouse

  1. Add a second entry to the Shukuchi stack, in which the target option is "Mouse Location", ensuring that the first entry is still "Target"
  2. With the Moogle still targeted, place your mouse cursor somewhere other than the Moogle, and use Shukuchi via the chat box
  3. Observe that your character executes Shukuchi at the mouse location, rather than the target
  4. Use Shukuchi via a hotbar
  5. Observe that your character executes Shukuchi at the mouse location again, rather than the target

Video examples:

Target > Focus Target is an invalid priority when Focus Target is untargetable

If you setup a stack for an offensive spell like this, and your focus target goes untargetable, you will not be able to cast the spell on your target, unless you un-focus your focus target:
image

For example, enter The Navel and focus target Titan. Now target Titan. You can successfully cast malefic IV on him using the stack above.
Now progress to his "heart" phase, where Titan (your focus target) becomes untargetable. Target "Titan's Heart" and try to cast Malefic IV. You can't (invalid target), unless you remove Titan as your focus target. This is despite the fact that "Target" is higher in the stack than "Focus Target" is...

image

Finally, I'll add that Target > Focus Target works perfectly fine when the focus target isn't untargetable. For example if you focus target Dummy 1 and target Dummy 2, your spell will fire on Dummy 2. If you untarget Dummy 2, your spell will fire on Dummy 1.

Japanese client

I could use it with a Japanese client before the update, but after the update it can no longer be used at all.
Do you have any plans to support Japanese clients?
image

NPCs not Included

Thanks, for the great plugin. Was wondering if you would consider allowing NPCs to be healed by mousing over them (similar to how <mo> works when used in a macro). They don't seem to count as field entities from what I've seen.

Edit: Targeting a healable NPC and hovering over the UI element also doesn't work.

Ground target skills position validation problem.

According to the code here, there is no check which determines whether our mouse position should be able to place a skill and no check for the clamped position either.
That will create situations like "positioning a asylum in the middle of e3s when it is impossible". I am wondering if it is fixed in the new version but there is no push for now.
Btw,please fix the animation that use a skill while casting. Thanks.

Multiple stacks for one ability

I have a (maybe not so?) niche use case, as a controller player who dabbles in AST. I currently have 8 play macros set up, one for each party member, so my hotbar of play macros looks like this:

image

As far as I can tell, MOAction can't do this, unless I just haven't read carefully enough. Using mouseover actions is pretty difficult with a controller and I often fumble trying to manually target party members, so this feature would be really helpful for me.

Riposte > Vercure mouseover does not function correctly

When setting up Vercure to be cast in place of Riposte it does not attempt to cast Vercure in place of Riposte.
riposte

If I setup a separate Vercure mouseover as shown below, then the Riposte mouseover will function after I've used the Vercure mouseover once. It will stop functioning again after I open MOAction config, at which point I need to use the Vercure mouseover once more for the Riposte mouseover to work.
vercure

Even after this, the Riposte mouseover fails to function when Swiftcast or Dualcast are active.

Mouse Location stack does not check for cooldown / gcd / resources

As of current, unlike the similar feature from akira0245's smartcast (currently unavailable on api4), MOAction stacks with the property "Mouse Location" on an ability such as Feather Rain, Sacred Soil, or any other 3d world targeted ability does NOT account for cooldown / gcd or even missing resources and will play the animation of the ability regardless

I have 0 idea on how to fix this, but it might be of use looking at how akira0245's smartcast handles checks for being able to cast the spell

Also, this is NOT an issue on any of the other stack properties such as field / ui mouseovers from my experience, only Mouse Location

Heres a clip to demonstrate what happens when casting sacred soil with 0 resources / during GCD: https://streamable.com/38dn73

Couple additional mouseover abilities request

There are a couple sets of abilities I'd like to see a mouseover option for, if possible. Both of these unavailable in Action Stacks mode, but I'd also like them in the set-and-forget "old configuration" mode if possible.

  • [Ninja] Most of the Ninjitsu effects would benefit from being about to be mouseover. Specifically, Fuma Shuriken, Katon, Raiton, Hyoton, Huton, Suiton, Goka Mekkyaku, and Hyosho Ranryu. Might be as easy as applying it to Ninjitsu, since it turns into these effects, but it'd also need to apply to the 3 Mudra for use during Ten Chi Jin (since that converts the 3 Mudras into one of the above Ninjitsu casts, depending on the order they are hit in).

  • [Samurai] Tenka Goken. Similar to Fuga and Hissatsu: Guren, cone attacks almost mandate having a mouseover set, since they cannot be cast without a target selected and within the target area. Kaeshi: Goken as well, for the same reason.

AST : Drawn Cards

I don't know if I'm missing something or if it's an oversight but, I don't manage to create a stack for :
The Balance id : 4401,
The Arrow id : 4402,
The Spear id : 4403,
The Bole id : 4404,
The Ewer id : 4405,
The Spire id : 4407,
Lord of Crowns id : 7444,
Lady of Crowns id : 7445

I tried creating the json, converting it to string64 and importing it but it didn't work

EDIT : I'm dumb I didn't realize you could add play and minor arcana...

Stacks interact strangely with sub-GCD-cast time spells

This is my stack for Stone/Cure (WHM):

ffxiv_10212021_114741_334

It works as expected under most circumstances. But if I press it with my mouse over a friendly target, while targeting an enemy target, when I'm on GCD but not currently casting a spell, during the ability queue window, it will queue Stone on the enemy target instead of Cure on the friendly mouseover.

The easiest way to reproduce this is to target an enemy, mouse over a friendly, and spam the button: it will alternate between casting Cure on the friendly and Stone on the enemy. Because of this, I initially thought the problem was that Cure went "on cooldown" until the end of its GCD (since the recast is longer than the cast time).

However, I can also reproduce it by casting Aero on an enemy target and then immediately trying to cast Cure on mouseover: it casts Stone on my target instead. So the GCD itself seems to be the issue.

Interestingly, an identical stack with the base ability set to Cure works perfectly as expected. So the problem isn't just "the base ability fires if the stack fails"; if that were the case then I'd be accidentally Curing myself when trying to spam it on mouseover, which isn't happening.

Crash on use

image

Thats is the macro i setup. But it crashes game instantly every time its used. Does this need updating for 5.3?

Spell up and downgrades

I am currently using several healing macro's that will auto downgrade for level sync to avoid button bloat. I stumbled onto your plugin and I see that you do this for the dps spells, however the healing spells do not do this. Example job (AST) spell Benefic Lv2, and Benefic II Lv26. These spells do not downgrade like spell Malefic IV does all the way to Malefic depending on the level sync. Is this a possible option for the near future? The macro's I have work fine however I would like to eliminate the macro delay especially when healing. Here are 2 examples of my macro's:
Greater than and less than symbols before and after "" comments would not let me use them.
/micon "Benefic"
/macroerror off
/ac "Benefic II" mo
/ac "Benefic" mo
/ac "Benefic II" f
/ac Benefic f
/ac "Benefic II" me
/ac Benefic me

and for AOE heals for the down grade able level sync

/micon "Helios"
/macroerror off
/ac "Aspected Helios"
/ac "Helios"

If this request is at all possible, it would be greatly appreciated.
Thank You

Nice to have - Certain abilities triggered when status met

A nice feature to have would be for certain abilities are resolved one way if a condition is met, or another if its not met

Example: Dragon sight and party count is 4, and different if party count is 8, although party sorting of list could manage this somewhat.

Another example: Heart of stone, if i have active aggro, use on me, otherwise use on target of target

Cannot copy stacks to clipboard

image
This error pops up whenever I try and the plugin just stops working until I restart my game. Nothing is copied to my clipboard either.

Handling of Unlearned Abilities

I'm aware this isn't really the intended use case of this plugin, but it would help my narrow silly use case if unlearned abilities were handled differently. What I'm trying to do (and can do, clunkily, with a macro) is basically as levelling SCH put Ruin I and Ruin II on the same button, so that Ruin I is cast if I'm synced too low to use II. I am aware this is kind of silly, but my neurosis wants to save the bar space anyway.

As is, it seems like any stack with an ability that's currently "unlearned" due to being synced to a lower level just fails immediately upon hitting that ability in the stack, instead of just seing it as a normal . So Ruin II being uncastable blocks Ruin I from being tried.

I'd appreciate it if moaction would just skip over unlearned abilities in a stack, or something similar, if possible. I'm fine with the "base" ability needing to be learned, as I could see that being a technical limitation, this is just about stack behavior.

image

DRK - Salted Earth not in Action stack setup list

I tried looking through the code to determine how Ability lists were populated, but couldn't exactly figure out why Salted Earth is not one of the abilities represented. I often use Salted Earth either as mouseover or on my self. It's ground target by default.

Add instant ground placement

Whether it be at self, target, mouseover, or current mouse location, I'm not sure. This may also be better suited as a separate plugin.

Role Abilities only work for 1 job

If you setup a Role ability as the base action it will only work for 1 class. To give specifics of how I am running into this issue, I have Esuna setup for both SCH and WHM with Esuna on UI and Field Mouseover and then a damage ability on Target. Currently the damage ability will only work for WHM, I get an error on SCH saying I can't use that ability on that job.

UI mouseover action does not work on enemy list.

I would assume that the UI mouseover would work on all UI, however it does not seem to work on the enemy list. Mostly not an issue but as a tank not being able to UI mouseover the enemy list to taunt is a bit of a letdown.

bug with AST spells

sometimes my benefic ii will cast aspected benefic on the target when i mouseover, not sure why this is happening, any help would be appreciated

Remove stack option

It seems like there's no remove action from stack that I can find. Would be nice.
image

Question regarding future functionality.

Would it be possible to have one keybind use two different spells/abilities based on whether my mouse cursor is over the party list or not.

For example: When my my mouse is over a party member and I press keybind 1 it casts cure 2. When my mouse cursor is not on the party list the same keybind casts glare.

Target option: nearest enemy

I'm not sure if this is feasible, and even if it is, if it fits within the scope of what you want this mod to do, but there are a couple abilities I'd love to have automatically execute on the nearest target if I don't have one selected.

The primary use case for this, to be honest, is cone and line attacks. I'm not sure why FFXIV requires that these type attacks have a valid target, but it's annoyingly common for me to be AoEing with a cone attack (Quick Nock, Moulinet, Fuga, etc), and for my target to die and thus my AoE to stop going off unless I'm really on top of slapping the tab button the instant my target drops (and I can't simply spam tab, because FFXIV will happily tab to that target that's not in combat and that's 50 yards away in the next room, rather than just the ones in-combat and immediately in front of you). Basically, would serve as a way of negating one of the aspects of FFXIV targeting that I find most infuriating, that an AoE attack that's not target-centered still, for no rational reason I can discern, mandates you have a target that's within the area of the attack (meanwhile ground-target and PBAoEs don't). It's really the only thing that keeps me from enjoying Samurai and Warrior, both of which require a cone leading to their AoE (and in the case of Samurai, also on their AoE Iuijutsu >.>). Another use-case would be for targeted follow-up AoEs from untargeted AoEs (ex. Fan Dance II -> Fan Dance III).

Basic concept of function would be setting it after target in the stack list, and have it mechanically function either identically to tab target (not sure if you can just directly call the tab target functionality), or unconditionally target nearest. Maybe both as options (target next and target nearest)? Might also be worth having it for nearest ally, though the only real use-case I can think of for that atm would be Dragoon's Dragon Sight so you don't have to go hunting for a target or muck with focus macros for it.

If that's beyond the scope of what you want this plugin to do, though, c’est la vie. I understand it could be seen as at least nudging the line on automation, but I feel like it's more addressing a specific weakness of the FFXIV targeting system, which is more or less what mouseover targeting is for as well.

Stacks do not seem to be working - WHM, DIA

I have the current stack example setup I have the current example stack setup

And it just simply refuses to work, be it hovering over the enemy list, or just hovering over the targets on my screen.
This update seems to have broken the addon.

"Target" target does not work for NPC's

image

Having the stack set up as above, targeting an NPC and casting Cure II would cast the Cure II on self. If the stack is deleted, NPC can be healed normally. It seems stack #5 in above screenshot is not working for NPC's.

Usage in PVP zones

Hello! I've been trying to use this in any pvp zones, and it does not work. It does work in any other zone so I thought maybe it was a bug. If it is intentional so as to not give an advantage over the other teams, that's fine.

The behaviour also occurs in the wolf's den, if that is of any use for development purpose :)

feature request: fall through to next stack entry when target is invalid

For example in this stack entry:

W3siQmFzZUlkIjozNTQyLCJTdGFjayI6W3siSXRlbTEiOiJVSSBNb3VzZW92ZXIiLCJJdGVtMiI6NzM4Mn0seyJJdGVtMSI6IlRhcmdldCBvZiBUYXJnZXQiLCJJdGVtMiI6NzM4Mn0seyJJdGVtMSI6IlNlbGYiLCJJdGVtMiI6MzU0Mn1dLCJNb2RpZmllciI6MCwiSm9iIjoiMTkifV0=

Base Action -> Sheltron
UI Mouseover -> Intevention
Target of Target -> Intervention
Self -> Sheltron

I would like to see a press of Sheltron cast intervention on the UI mouseover target if one is moused over, or the target of the current target (likely the MT), and then if that doesn't work then fall back to sheltron on the player.

I'm getting an "Invalid Target" error message when I have aggro of the target because it is trying to use Intervention on me. It falls through to the next stack entry if there is no target but does not fall through if the target is invalid. It'd be cool to also fall to the next stack entry when the target is invalid.

Thanks! Love the mod and the new more powerful customization system!

Feature Request: Add actions to stacks not stacks to actions.

Having to setup the same stacks over and over for multiple spells/abilities is tedious and a pain. This also makes it harder to change the behaviour if you decide you would rather things work in a different manner. Right now we add stacks to actions, but a much less time consuming method would be to have us create the stacks and then assign which actions go onto those stacks. This is a bit of a bigger ask and would require a new UI, but ultimately it would create a much simpler and cleaner experience for the user and greatly reduce the time it takes to set things up.

What are action stacks?

I couldn't find any explanation for this plugin. What are "action stacks"? I do understand the mouseover settings, but those apparently are using the "old configuration". Can someone maybe explain the difference between the two? Thank You

Add Draw Action for AST

Would it be possible to add the Draw action for Astrologian? I currently have a macro tying Draw into Play so that it operates on one button like it used to.

Thank you!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.