attilathehen / oriole Goto Github PK

That might be cleaner than some of the components, that have a long ternary chain.

What the title says.

Harvest will send back an HTTP 429 error code if the rate limiter kicks in. Handle this! And add better error handling in general.

This is the big 'un. When this command is run, several things need to happen:

• By specifying the path (.), oriole save should be able to read the git log output of that current directory, or else throw an error if the current directory is not a git repository.
  • The user should also be able to, therefore, enter a different directory, and not just the current one.
• The --time parameter should indicate how far back oriole should look in the git log output. If, for instance, the time value was given as --8, oriole should only grab the commits within the past 8 hours.
  • Might be nice for this to have a default - maybe 8/10 hours?
• oriole save should also format the git log output in a nice way:
  • Remove semantic commit type prefixes such as "fix:", just because I feel like they would clutter up the Harvest log
  • If it's a multiline commit message, format it accordingly with nice indents
  • If any sort of ticket information is given, like "[ch####]", use that to create a nice heading for the entry up top, like "Ticket #####:"
    • However, if there are already time entries in Harvest that have the same heading, simply add the relevant commits to it rather than creating a new one (related to the next bullet point). Therefore, we'll have to first read/GET the current Harvest entries before POSTing?
• Make sure it's idempotent (obviously)
• Show the output/nicely-formatted entry either before or upon POSTing - maybe allow the user to edit it beforehand?
• This somehow needs to work together, in a streamlined way, with #2 and #3. Several different ways to go about it - either add them as params, which would make the command quite long (oriole save . --time --project --task), or have a couple prompts after inputting oriole save . --time that specifies then and there. Or...some other way? Is there anything about the directory that the CLI can get info from? Or maybe the user does it once, and then it saves?

See if there's a Harvest API request that makes this easy? And if not, investigate how easy/expensive this would be.

What's going on here?

See here: https://docs.github.com/en/free-pro-team@latest/actions/guides/publishing-nodejs-packages

It would make it a lot easier to see the changes happening in the store. And also add scripts to create/delete the store?

Also, if dev mode is enabled, use saved JSON files so I'm not spamming the Harvest API.

I did a oriole setup added my personal access token and account ID and then when running oriole init inside a repo I got the following:

> oriole init
🕐  Loading...
/Users/danielrb/open/oriole/node_modules/yoga-layout-prebuilt/yoga-layout/build/Release/nbind.js:53
        throw ex;
        ^

SyntaxError: Unexpected token i in JSON at position 8
    at JSON.parse (<anonymous>)
    at /Users/danielrb/open/oriole/build/commands/init.js:857:25

I will continue to investigate but any help would be useful.

Let a user select from the list? Or just show? Then copy project ID?

UPDATE: This needs be something more like oriole set or oriole set ., where oriole will make a link between the current directory and a Harvest project belonging to the user.

🐳

When deleting the key generated by oriole setup from your OS's keychain, and also deleting the orioleStore.json file, there's an issue where running oriole setup immediately afterwards fails. Running oriole setup a second time works properly, but the first time after deleting both the store JSON and the secret key always fails.

Investigate 🔍

What the title says - allow oriole push to accept a --merge, -m flag that bypasses the prompt. Maybe if you set it to true, it merges, and if you set it to false, it creates a new? So allows the user to bypass and go to either of the options?

PRIORITY: add some sort of confirmation option for oriole push when it finds the same project/task entry - something like "We've found a timesheet entry with the same project and task. Would you like to overwrite and update this one, or create a new one?"

That might be nicer UX than immediately overwriting, like it is now?

Without something like this, the user could potentially overwrite their entire other entry that they wrote by hand - that's not ideal. Some sort of "merge" option could also be introduced, but that would definitely need more thought and work. For now, allow the user to simply push a new entry separately.

Related to #2.

Similar question applies - how to go about letting the user make a selection, and save that selection.

See the image in #28 - commit messages should be oldest -> newest, top -> bottom.

Might be nice to have.

It's pretty out of date at this point.

Why haven't I done this already lol

Take a user's Harvest token and Harvest User ID value and save it to use when making requests.

• Also, save it so that they don't have to keep entering it over and over again.
• Also, think about security, and how to go about safely storing these values?

We need tests!

Something like "oriole get all" that tells you what project/task has been selected for the current directory.

Add functionality for oriole to look at previous days, or go back to a previous day and get the git commits.

Because why not?

Related to #41. Change it so that it's no longer only looking at commits made between 6am and 6pm. All commits made during the whole day should be found.

Seems like a good idea.

Even with the store encrypted overall, it's probably not a bad idea.

Related to #2.

Similar question applies - how to go about letting the user make a selection, and save that selection.

Right now it just runs oriole.