audriga / scim-server-php Goto Github PK

While testing Azure AD SCIM provisioning with the PR for a Nextcloud app at https://lab.libreho.st/libre.sh/scim/scimserviceprovider/-/merge_requests/2 I discovered what I think is a limitation/bug in this SCIM library rather than the NC app.

In short, I got this error in the logs:

Opf\Models\SCIM\Standard\Filters\FilterException: Incorrectly formatted AttributeExpression in /var/www/html/custom_apps/scimserviceprovider/vendor/audriga/scim-server-php/src/Util/Filters/FilterParser.php:29

The request was:

GET /Groups?excludedAttributes=members&filter=displayName+eq+%22EDU+All+personal%22

So, the filter that is requested is this:

displayName eq "EDU All personal"

Looking at FilterParser::parseFilterExpression() it seems that it simply splits the filter string on the space character and verifies that the number of elements from that is two or three. It does not seem to take into account quoted values (strings are always quoted in this context), parentheses and similar filter formats.

As far as I can tell, spaces are perfectly valid in strings, according to the SCIM Core specification which references the JSON specification. Regarding filter formats there is support for grouping using () and more complex filtering using [] described here.

On a related note, I noticed that while there's about six groups in the Azure AD I'm testing with, only two of them are synced. It seems that the two that are synced have no spaces in their names, while those that are not synced do have spaces in their names. So perhaps that part is related to spaces as well (could be due to a query failing due to the above filter issue, I haven't digged into this at all yet).

Make it easier for developers to find this package and include it in their project by registering it on packagist.org. Shouldn't take more than just a couple of minutes.

I was looking for a package like this but had a hard time finding something usable and only accidentally stumbled on this package in github.