GithubHelp home page GithubHelp logo

Comments (4)

cxj avatar cxj commented on August 26, 2024

How would the Auth object be notified that the password had been changed? That seems like an external operation.

Perhaps there should be an Aura.Auth public method for intentionally invalidating a session? Such a method would then be called by application code which changes the password.

from aura.auth.

jakejohns avatar jakejohns commented on August 26, 2024

Isn't the LogoutService the way to invalidate a session?

I don't agree that a change in the credential persistence necessarily
invalidates a session. I don't want to authenticate again if I change my
password.

If you really wanted the implied functionality, I think you'd modify your use of
the ResumeService with some conditional logic that checks the last auth time
against the last change in the credential persistence? Whatever you did, you'd
be hitting the credential persistence on every request tho, so it doesn't seem
that great.

from aura.auth.

azaiter avatar azaiter commented on August 26, 2024

My initial idea is to have something like what @jakejohns mentioned on editing ResumeService. But it will add more overhead to the checking mechanism (implied login on each time the session is validated). Sometimes this could be essential in a "higher" security system. After seeing your opinion on this, I'm not sure if this could be another functionality request or just close it out as it could be not necessary.

from aura.auth.

harikt avatar harikt commented on August 26, 2024

3- Check auth->isValid() is also still true.

Once you use the credentials the validity is verified at the time only. So it no longer checks the password you entered .

But since the password is invalid, the session should be invalidated.

You can do this via logging out the user when the password is changed as @jakejohns already mentioned.

This is outside the scope of this library.

from aura.auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.