New release builds, please? about aura.auth

[pmjones]

Oh, I thought he already had been added. Thanks @harikt !

[harikt]

Hi @cxj ,

I have added you as a maintainer. I hope @pmjones will also agree without any hesitation .

Keep things moving forward. I will be around in case if you need any help.

[harikt]

@cxj I agree with you, but I think it is up to the users to modify his / her session.gc_maxlifetime . If someone in the @auraphp/docs-team can give a green card. I will do. For me it looks not good.

[harikt]

Sorry I have not seen this message. I can look into this in the coming days and do a release. Anything I need to take special attention to ?

PS : In case I miss again, please ping me.

[cxj]

Nothing special. Just having a tag I can use in my composer.json file for releases would be very helpful.

[harikt]

ok, I will do it tomorrow early morning.

[harikt]

Hi @cxj ,

I looked into this, and noticed my comment on #84 (comment) . The default session.gc_maxlifetime => 1440 => 1440 . And the PR #84 already made the change. As it is config for Aura framework, that may not have broken users. But the PR #89 will.

What I would suggest is to override the values passed to Timer

Aura.Auth/config/Common.php

Lines 101 to 106 in 955ef97

	$di->params['Aura\Auth\Session\Timer'] = array(
	'ini_gc_maxlifetime' => ini_get('session.gc_maxlifetime'),
	'ini_cookie_lifetime' => ini_get('session.cookie_lifetime'),
	'idle_ttl' => 3600, // 1 hour
	'expire_ttl' => 86400, // 24 hours
	);

with your own. That will actually fix your problem.

For the current time I don't think I can make a release and I believe the patch #84 need to be reverted.

[cxj]

I have already changed the values in my copy of Aura.Auth/config/Common.php to suit my needs. PR #84 and PR #89 were designed to change the default value used by Aura.Auth to be a sane, intelligent value for all future users of Aura.Auth.

The default value used by Travis of 1440, and in the PHP releases of the php.ini file with session.gc_maxlifetime = 1440 are erroneous. See https://stackoverflow.com/questions/14703363/why-is-the-standard-session-lifetime-24-minutes-1440-seconds/37176824#37176824 for the full explanation.

[Qrzysio]

I agree it's up to users how long session.gc_maxlifetime should be. It's quite annoying now to deal with this low limit. I would really appreciate to see a new release which fixed this issue.

[harikt]

I agree it's up to users how long session.gc_maxlifetime should be. It's quite annoying now to deal with this low limit.

Why not override the default config.

I would really appreciate to see a new release which fixed this issue.

I will look what I can do.

[Qrzysio]

Well, I didn't want to touch the source, so in case of an update, I do not lose my "fixes". I didn't expect there will be no updates at all for a long time ;).

Anyway, I've tried hard to manage the behaviour of how long the sessions are and how to manipulate the timer. Probably my knowledge is not good enough to get it, or the script itself does not allow to extend the time of being logged in.

@ini_set("session.gc_maxlifetime", 3600*24);
@ini_set("session.cookie_lifetime", 3600*24);

$aura = new \Aura\Auth\Session\Timer(3600*48, 3600*24, 0, 0);
$aura->setIdleTtl(7200);
$aura->setExpireTtl(3600*24);

[harikt]

You don't want to change source. You can add another config . Ie what I meant by override. I think I have commented about it on this thread. So you don't want to rely on the changes happening on config of package.

…

On Sun 18 Nov, 2018, 7:27 PM Qrzysio, ***@***.***> wrote: Well, I didn't want to touch the source, so in case of an update, I do not lose my "fixes". I didn't expect there will be no updates at all for a long time ;). Anyway, I've tried hard to manage the behaviour of how long the sessions are and how to manipulate the timer. Probably my knowledge is not good enough to get it, or the script itself does not allow to extend the time of being logged in. @ini_set("session.gc_maxlifetime", 3600*24); @ini_set("session.cookie_lifetime", 3600*24); $aura = new \Aura\Auth\Session\Timer(3600*48, 3600*24, 0, 0); $aura->setIdleTtl(7200); $aura->setExpireTtl(3600*24); — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#97 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHWhpxqs66p4_JhXjk5XCOtl_He4lt1ks5uwWc4gaJpZM4U4vZo> .

[harikt]

@pmjones I have added him to Aura.Auth for now. I don't see a way to add him to the team. Oh and you are fast to reply 👍 .

[cxj]

Obviated by having a 4.x branch with the needed changes.