PHP Notice during cron related to Sync about jetpack

[bindlegirl]

@fgiannar or @darssen Could you take a look at this one?

[dd32]

Unfortunately due to these being triggered in the delete action, I'm unable to inspect the data after the fact, and I haven't attempted to manually replicate it.
The logs I have access to don't include any stack traces other than what's shared either.

Technically #37817 would resolve it, but I don't necessarily think that's the best route forward, unless it's expected inputs that cause it. I don't think just removing the notice without understanding the cause is always the correct choice - sometimes it's "obvious" but this is one of those cases where it doesn't quite make sense why it's happening, and so, I'd personally err on the side of figuring that out instead.. even if it means the notice remains for months..

[darssen]

Hi @dd32!

I see this looks to be happening for you when grunion_delete_old_spam is triggered by cron. I have not been able to replicate and even do some tests manually calling the function and deleting some posts have not incurred in the notice in my local server. If you could provide some more details on replicating or maybe get some error logs with the content of the args in filter_meta I'd appreciate it.

In any case, I have created #37817 which should take care of the issue by adding checks that ensure the array is well formed.

[darssen]

Hi @dd32!

I agree with you about the solution not being the more elegant.

I did try to replicate without luck (Details here p1718270572657889-slack-C011BCGRMBR)

Would it be possible for you to add logs on filter_meta since in the summary you stated that you have seen the PHP notice often hit? This way we might be able to pinpoint the issue :)