avalonmediasystem / puppet-fcrepo Goto Github PK

https://github.com/mbklein/puppet-fcrepo/blob/master/manifests/init.pp#L16

After tomcat package install, contents of /etc/sysconfig/tomcat:

export JAVA_HOME=/usr/lib/jvm/java
export JAVA_OPTS="-Dfile.encoding=UTF-8 \
  -Dcatalina.logbase=/var/log/tomcat7 \
  -Dnet.sf.ehcache.skipUpdateCheck=true \
  -XX:+DoEscapeAnalysis \
  -XX:+UseConcMarkSweepGC \
  -XX:+CMSClassUnloadingEnabled \
  -XX:+UseParNewGC \
  -XX:MaxPermSize=128m \
  -Xms512m -Xmx512m"
export PATH=$JAVA_HOME/bin:$PATH

After puppet run:

Notice: /Stage[main]/Fedora/Concat[/etc/sysconfig/tomcat]/File[/etc/sysconfig/tomcat]/content: content changed '{md5}139dc62bd63bd5cbfb535ae2920d0f17' to '{md5}b6ef6847e7e41b2898001801dba2b276'

FEDORA_HOME='/usr/local/fedora'

Maybe we can construct /etc/sysconfig/tomcat from scratch to include all we need.

There are some implied, third-party dependencies in your manifest. It'd be great for your downstream consumers if you provided a librarian-puppet Puppetfile!

Some people might want to use mysql as the backing-database for Fedora. You should let them do that. (There's a pretty nice mysql package for puppet too). I hear @cbeer might have something to do this already...

The fedora puppet class shouldn't force you to use a particular version of Fedora. Please consider allowing the fedora version (or, even, the entire url to download fedora!) to be passed as an argument.