Decompilation output is shown in a wrong window when clicking inside Output window about retdec-idaplugin

[PeterMatula]

Rewrite to IDA SDK 7.0 did not help. This is still happening.

I tried to solve it, but I did not succeed. I tried to play with different WOPN_ combinations, different parent widgets for create_custom_viewer(), and looked for related functionality in kernwin.hpp, but nothing helped.

I have no more ideas, maybe someone can help.

[PeterMatula]

This issue is even worse I realized. Weird RetDec window jumping is also happening when function renaming action happens. The window gets docked to the right of the current ASM output window. I played around with set_dock_pos(), get_current_widget(), and get_current_viewer(), but so far no luck.

[PeterMatula]

Getting a get_current_widget() when decompilation is triggered and activate_widget() it before display_widget() of decompilation result works, but the problem is if the widget that was taken is closed in the meantime. That will cause segfault.

Simple solution is to use jumpto(decompiled_function->start_ea) before showing the function. This should be always safe and it should take care of all the problems I can think of at the moment. The only downside is that we are changing position in IDA view without users requesting it. But it is probably not a big problem.