avi-meshulam / weather-app-ts

A client-server web application with TypeScript and Node.js

weather-app

A client-server web application with TypeScript and Node.js

Tools & Libraries

• Node.js - Server
• node-fetch - Communication with Weather API
• OpenWeatherMap - Weather API
• Leaflet - Interactive map
• leaflet-color-markers - Map markers
• lodash

Features

Responsive design - The display is adjusted to fit screen

Caching:

Server side:

• Static files (html, css, js, json, images)
• Weather data (upon request, with a predetermined expiration time)

Client side:

• Cities data (names, coordinates, countries etc.)
• Weather data (upon request, with a predetermined expiration time)

Installation & Run:

1. Open command prompt in 'weather-app-avi' folder
2. Type 'npm install' to install all the required packages for the application
3. Type 'npm start' to start the server
4. Open a browser at http://localhost:8080

Routes:

Route	Description
/	Root - Weather data is not displayed and map is scaled to fit the world
/weather?city={city},{country}	City's weather - Displays the weather of the selected city and zooms the map on that city

User Interface

Selecting a city:

Option 1: Select a city from the dropdown list above the weather panel

Option 2: Click on a city marker on the map

Upon selecting a city, the map is zoomed on that city and the city's weather is displayed in the weather panel

weather-app-ts's Issues

Review

Avi

Sanity check: OK

Code inspection: OK

• See typo

Project Structure: Good

• Prefer using class over id selector for css styles

Readability (Complexity Magic numbers, function / line length): OK

• What are *.map files?
• filterJSON - please explain
• Why simulating clicks with dispatchEvent? Make a generic function instead.
• Some long functions (over 20 lines)
• Suggestion - see simple projects of as inspiration for simplicity

Naming (files, functions, variables): Good

• Some functions are not very clear (see filterJSON )
• main.ts - Do not name simple map object with cache extension, if not functioning as actual cache (cities, markers)

Efficiency: OK

• Why dealing with Optionrequests?
• Caching on client is client responsibility (which can be done using storage object). Cookies determined by server - should be for authentication / server session management (As a last resort)

Documentation (Readme, inline):

• Great Readme. thumb’s up :)
• Server files - require more comments

Error handling: OK

• Some error occur once on browser (couldn’t reconstruct)

Unexpected request handling: OK

• User can see path and file not found errors - http://localhost:8080/gg.gg

Cleanup (remove unneeded conde, comments etc.): OK