avniproject / avni-health-modules Goto Github PK

This issue was raised as part of a ticket

Fix needed:

1. Throw proper error when common.getDays() and common.copyDate() functions are invoked with invalid date params.
2. In the various organisations that have been impacted,
   • Check the ruleTelemetry to find instances
   • correct the rules if needed to invoke the function with valid date for common.getDays() and common.copyDate() functions
3. Check data passed to these methods from health-modules code. Fields under focus: DOB, enrolmentDateTime, LastMenstrualPeriod, etc..
4. upgrade avni-health-modules versions in webapp, client and rules-server

Acceptance criteria

Instead of a generic non-meaningful message such as

undefined is not an object (evaluating 't.getTime')

Ensure that error message shown is readable and helps implementers understand the root cause of an issue:

Invalid date value \'${date}\' specified for mandatory concept \'${fieldName}\' for entity \'${entity}\' with uuid \'${entityUUID}\'`

Motivation

As an Avni developer, I want to be able to use core rules from avni-webapp. To do this we need to move core rule files from our mono repo avni-client to our npm package avni-health-modules. We need to copy all the tests also.

Acceptance Criteria

• Check that all the health module files in avni-client/openchs-health-modules are moved to the avni-health-modules repo.
• Test that running make build generates compiled javascript for the added core module rule files in the dist folder.
• Check that all the tests are also copied and passes.
• Check that all the existing rules using common and motherCalculations modules work as it is in avni-webapp.

Tech Tasks

• Copy core rule files to the avni-health-modules repo from avni-client. Add the required babel plugins to the avni-health-modules repo.
• Copy the tests also and make sure that they pass.
• Add test job in CircleCI pipeline. Make publish job dependent on test job.
• Publish a new version of avni-health-modules.
• Upgrade to new version of avni-health-modules version in avni-webapp and avni-rules.

Testing senarios

• Check the test cases in avni-health-modules.
• Updated version of avni-health-modules in webapp should work as it used to earlier (test if common functions are available).