awilkey / fullscreen-jbrowse Goto Github PK

Looks like the parsing of the window url isn't working properly.

My URL:

http://localhost:8080/?loc=3%3A52436758..52436940&tracks=DNA%2CProportionalMultiBw-XY%2CprotCodeTrans&highlight=

Errors from console

main.js:110
Uncaught TypeError: Cannot read property '1' of null
goFull @ main.js:110
onClick @ main.js:120
_onClick @ _ButtonMixin.js:58
(anonymous function) @ lang.js:373
__onClick @ _ButtonMixin.js:45
(anonymous function) @ lang.js:373

Regards,
Keiran

First off, this is an awesome little plugin and Exactly what I needed! That said I'm having some issues when I try to use it within an iFrame.

When I look at a particular JBrowse instance on it's original page (not in an iFrame), the Fullscreen button shows up and works beautifully!
However, when moments later I look at the same JBrowse instance (in an iFrame) on the same browser and the same computer, I get told that fullscreen is not supported for my browser. Obviously it is supported since I just used it but the plugin seems to be having difficulty detecting this.

You can see this in action yourself by comparing the following:
Original: http://knowpulse.usask.ca/jbrowse/Zmxdm-Mt4.0/
iFrame: http://knowpulse.usask.ca/portal/jbrowse/Medicago

I'm using Chrome 48.0.2564.103 on Mac OS X 10.10.4 and the most recent version of your plugin (cloned yesterday :-))
I've also confirmed I get the same message on Firefox 44.0

I have cleared the cache to the "beginning of time" so it shouldn't be a JBrowse caching issue, right?