aws-samples / eks-blueprints-workloads Goto Github PK

The repo https://github.com/CarmenAPuccio/GeoLocationAPI that is used for the team-carmen workload example has changed its default branch from master to main. This needs to be fixed in a few places:

• https://github.com/aws-samples/eks-blueprints-workloads/blob/main/envs/dev/templates/team-carmen.yaml#L16
• https://github.com/aws-samples/eks-blueprints-workloads/blob/main/envs/test/templates/team-carmen.yaml#L15

Reproduce Steps:
Go through SSP QuickStart guide https://aws-quickstart.github.io/ssp-amazon-eks/getting-started/ and use the example under section Deploy workloads with ArgoCD

Expect Behaviors:
The command
kubectl port-forward svc/guestbook-ui -n team-burnham 4040:80
work as described

Actual Behavior:
The command fail with resources not found

Analyze:
If going into ArgoCD and check, following error happen on team-burnham
github.com_aws-samples_ssp-eks-workloads/teams/team-burnham/dev/Chart.yaml: no such file or directory

The problem is under team-burnham, it is not using template, but rather direct deployment yaml in default branch

That file seem to be deploy nginx, which seem not correct (if compare to the other team folder).

There is a branch with different implementation
https://github.com/aws-samples/ssp-eks-workloads/blob/bugfix/update-repo-target/envs/dev/templates/team-burnham.yaml

Possible suggestions for fix:

1. If the default yaml is used (no helm), than may consider to modify to not use as helm
   https://github.com/aws-samples/ssp-eks-workloads/blob/main/envs/dev/templates/team-burnham.yaml

2. Bring the branch with the fix "bugfix/update-repo-target" into main

After discuss with @askulkarni2 , thought it is better to create an issue to start discussion on how should approach this to ensure SSP quickstart guide is more accurate and work correctly out of box

3. [Workaround] Fix within SSP Getting Start guide to change app-dev to use that branch bugfix/update-repo-target instead of default main branch

argocd app create dev-apps --dest-namespace argocd --dest-server https://kubernetes.default.svc --repo https://github.com/aws-samples/ssp-eks-workloads.git --path "envs/dev" --revision "bugfix/update-repo-target"

Or just update existing stack

argocd app set dev-apps --dest-namespace argocd --dest-server https://kubernetes.default.svc --repo https://github.com/aws-samples/ssp-eks-workloads.git --path "envs/dev" --revision "bugfix/update-repo-target"

4. [Workaround] Fix within SSP Quick start guide to use other team
   As following team is working in main branch
   https://github.com/aws-samples/ssp-eks-workloads/tree/main/teams/team-riker/dev
   Update the guide to use
   kubectl port-forward svc/guestbook-ui -n team-riker 4040:80

After discuss with @askulkarni2 , thought it is better to create an issue to start discussion on how should approach this to ensure SSP quickstart guide is more accurate and work correctly out of box

3 and 4 is not recommended as they are just workaround, but thought to bring to tables also