aws404 / simplejsonvillagertrades Goto Github PK

I think SJVT should throw an error if an invalid item is input into the JSON file. Its current behaviour seems to be to just replace the item with air.

e.g.:

{
        "type": "minecraft:sell_item",
        "item": "reaping:diamond_reaping_tool",
        "price": 13,
        "max_uses": 3,
        "experience": 30
}

should throw an error in your testmod, since reaping:diamond_reaping_tool isn't an item.

Potentially this should only happen if FabricLoader.genInstance().isDevelopment() is true.

Hello. I'm trying to use this trade offer factory, but the trades don't appear in the villager's ui. I'm following every step of the wiki.

This is what I wrote according with the trade offer factory options in the wiki

{ "type": "minecraft:set_potion_holding_item", "price": 3, "second_count": 5, "arrow": "minecraft_arrow", "sell_count": 5, "tipped_arrow": "minecraft:tipped_arrow", "max_uses": 12, "experience": 10 }

Note that in the example, the code seems simpler:

I tried using this way too, but nothing changed.

Being able to edit trades for existing professions is great, but it would be nice if we could add new professions as well.

Data changes go brrr

Hi, I'm just writing this to hopefully reach out to you about updating this mod to 1.18.2 at some stage.