axosoft / atom-github-notifications Goto Github PK

View Code? Open in Web Editor NEW

4.0 6.0 2.0 279 KB

Display and dismiss your GitHub notifications from inside Atom

License: MIT License

JavaScript 99.87% CSS 0.13%

atom-github-notifications's Introduction

GitHub Notifications

Display your GitHub notifications in Atom!

Setup

You must configure your GitHub personal access token to receive notifications. You can generate this token by following the provided link.

Built using by

atom-github-notifications's People

Contributors

Stargazers

Watchers

Forkers

samask connectionmaster

atom-github-notifications's Issues

why does it say github and nto github.com

u devs cant get anythign right

Link for issues doesn't work

For notifications that point to an issue, the link doesn't properly open the subject issue.

Unnecessary access token notification with every new window

Following on from my PR (#8)

Strangely, I still get the

GitHub Notifications
You need to add a Personal Access Token to get notifications from GitHub
Go add one

notification with every new Atom window no matter what… even though

const token = '' || process.env.GITHUB_TOKEN; // Empty string replicates no config setting…
if (!token) { console.log('no token') } else { console.log(token) }

logs the token…

The notifications from GitHub do show up generally (so the GITHUB_TOKEN environment variable is obviously being picked up as per #8)… just that the initial notification shouldn't appear, but does.

Continuous communication errors, even when disabled

I continue to get errors communicating with GitHub, even after disabling the package. I have tried deleting and generating another access token and restarting Atom but the errors continue.

When I do generate a new access token the notifications seem to work initially. However, after leaving Atom and coming back after some time all I get is errors.

Edit: I'm still getting these errors even after uninstalling the package. 😠
Edit 2: Restarting the app after uninstalling has solved ☝️

Uncaught TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict ...

This is what I did from the point of installing the plugin.

Add the plugin to Atom
Generate key
Set Mark as read option in settings
Went through and dismissed all of my notifications that came up
Start and update of other plugins that had updates.
Blurred the window.

Atom: 1.14.4 x64
Electron: 1.3.13
OS: Mac OS X 10.12.3
Thrown From: atom-github-notifications package 0.1.1

Stack Trace

Uncaught TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them

At /Users/johnh/.atom/packages/atom-github-notifications/node_modules/github-xhr/dist/error.js:104

TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them
    at /packages/atom-github-notifications/node_modules/github-xhr/dist/error.js:104:71)
    at XMLHttpRequest.ontimeout (/packages/atom-github-notifications/node_modules/github-xhr/dist/index.js:657:22)

Commands

     -7:59.1.0 settings-view:open (input.hidden-input)
     -7:54.3.0 editor:delete-to-beginning-of-line (input.hidden-input)
     -7:50.5.0 core:confirm (input.hidden-input)
     -6:47.2.0 editor:delete-to-beginning-of-line (input.hidden-input)
     -6:42.9.0 core:confirm (input.hidden-input)
     -4:34.3.0 core:paste (input.hidden-input)
     -1:13.5.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.seti-icons.seti-roboto.seti-animate.theme-base16-tomorrow-dark-theme.theme-seti-ui.find-visible)

Non-Core Packages

.bin undefined 
advanced-open-file 0.16.5 
atom-beautify 0.29.17 
atom-github-notifications 0.1.1 
autocomplete-clang 0.10.0 
dash 1.7.1 
docblockr 0.9.1 
editorconfig 2.2.2 
fonts 2.0.0 
git-time-machine 1.5.6 
highlight-selected 0.12.0 
hyperclick 0.0.40 
js-hyperclick 1.10.1 
language-babel 2.55.6 
language-gitignore 0.3.0 
linter 1.11.23 
linter-eslint 8.1.2 
merge-conflicts 1.4.4 
minimap 4.26.8 
minimap-find-and-replace 4.5.1 
minimap-highlight-selected 4.5.0 
minimap-pigments 0.2.2 
minimap-selection 4.4.0 
pigments 0.39.0 
regex-railroad-diagram 0.16.0 
seti-ui 1.6.1 
sort-lines 0.14.0 
Sublime-Style-Column-Selection 1.7.3 
tree-ignore 0.6.2 
vim-mode-plus 0.82.3 
vim-mode-plus-keymaps-for-surround 0.2.1 
wordcount 2.10.4

Thanks!
D.

Multiple atom windows duplicates notification toasts

When I started opening multiple atom windows I would get all of my notifications that I dismissed (and thought I "Marked as read" according to the setting).

Deprecation notice for authentication via URL query parameters

I just got 2 mails about this deprecation issue. Can you update your plugin for newer API?

Hi @XCanG,

On February 6th, 2020 at 21:42 (UTC) your personal access token (Atom GitHub Notifications) using Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Atom/1.43.0 Chrome/69.0.3497.128 Electron/4.2.7 Safari/537.36 was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/notifications

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated.

Depending on your API usage, we'll be sending you this email reminder once every 3 days for each token and User-Agent used in API calls made on your behalf.
Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.

Thanks,
The GitHub Team