ay2223s2-cs2113-t11-2 / tp Goto Github PK

I am able to add modules to year 99 which is not possible in NUS. This results in the module not displaying when I type the list command.

Labels: severity.Medium type.FeatureFlaw
original: nikkiDEEE/ped#1

1. Can remove unused code. Appears in several locations

This is not a bug but I feel it could be a somewhat misleading to the user. Maybe, you want to add (P) beside the module code if the module is under 'planner'. In this case, it looks as if the module is taken (yes, if it's taken, there will be grade beside it, but adding (P) could be more concise).

Labels: type.DocumentationBug severity.VeryLow
original: TopGun2001/ped#4

There are 2 modules added to the program. Firstly, one of the module has been added with a negative year as input. Secondly, when all the modules that have been taken are listed, there is only 1 module shown in display. The CAP is also incorrect as it takes the combined CAP of the valid and invalid modules.

Labels: severity.High type.FunctionalityBug
original: TopGun2001/ped#2

Handle exception for duplicate modules and y/ should be an integer

Good Effort on the DG! I have listed some feedback for the DG

1. Should commons be referenced by something, like Main maybe?

2. This is a non-standard representation of the class diagram. Refer here to update. Same for subsequent class diagrams

3. Try not to put the description in the middle, it is rather ambiguous as to where it belongs.

4. I think there are missing colons in the sequence diagrams and under the UI, the activation bar needs to be completely started. Likewise in the subsequent diagrams.

5. Self-invocation is missing an activation bar and I am unsure what the floating arrows are pointing to. This is recurring in the other sequence diagrams as well.

6. Unsure about the following. I believe they arose from merge conflicts, please ensure they are removed.

Display warning of prerequisites when module is planned

Initialise user according to engineering course for better core module status query

The description of cods is out of divider Len

Labels: severity.VeryLow type.FeatureFlaw
original: nikkiDEEE/ped#3

As a user I want to see my prerequisites and number of MCs for the module I am taking so that I can plan my timetable with prerequisites in mind.

As a user I can add modules so that I can make my study plan.

As a User I want to delete a module so that I can replace the existing module.

Save to penus.txt after every command

• NUSMods API feature
• Meaning of init: only serve one user at a time
• Warning of internet connection
• Status loading time
• Include limitations for each feature (compulsory fields, year, sem, mods)
• Difference between P and T in list

• When adding Taken- check if mod is suable if user types SU
• Mark as SU

1. Avoid magic numbers/strings. Try to use constants instead. Appears in several locations in the code base.

As a user I can mark and unmark a taken or untaken module so that I can keep track of what modules I have cleared

• Hashmap already coded out in Grade class
• Check through taken mods and add grade and mc, if grade is SU then skip
• Formula to calculate overall cap

Module has been added but when the input is list, output is NULL.
Not sure what's the reason behind this.

Labels: type.FeatureFlaw severity.High
original: TopGun2001/ped#7

As a user, I want to be able to see a list of all my modules which I have taken, am taking, and am going to take, so that I can plan for my upcoming semesters.

After module with invalid code "abcd" was added, list prints null instead of empty line

Labels: severity.Medium type.FunctionalityBug
original: DavidVin357/ped#2

As seen in the image, I've added a module with extra spaces at the end of the name. the result is that the list will show null.

Labels: type.FunctionalityBug severity.Low
original: darrenangwx/ped#2

User would not know what Error: g/ means

Labels: severity.Medium type.FeatureFlaw
original: nikkiDEEE/ped#2

Add destroy for CommandResult and XYZCommand
Add class names
Sequence diagram for DetailsCommand and ListCommand
Fix formatting

Make code more OOP (AddCommand, RemoveCommand, MarkCommand etc.)

As a user I want to see my graduation progress so that I can plan my graduation requirements

User does not know what to do with the error message.

Labels: severity.Low type.FeatureFlaw
original: nikkiDEEE/ped#6

Lists out all possible commands for user

Query API for module details

1. Remove code that are unused (don't comment them out)

2. Unsure what the <p> tag refers to here. Appears in several areas.

3. This is arrowhead coding. Please try to refactor

Use getResourceAsStream java API

No modules have been taken according the the program but the overall CAP is 4.5

Labels: severity.High type.FunctionalityBug
original: TopGun2001/ped#3

Incorrect CAP displayed

It should show 5.0 if I have passed a pass fail module

Labels: severity.Low type.FeatureFlaw
original: nikkiDEEE/ped#8

Not sure if this is a bug but a false module (does not exist) can be added. Perhaps what can be done here is to traverse the resources/modules file you have to search for the module code being input and use an isValid checker in the Logic package. (Apologies if I'm wrong haha)

Labels: severity.VeryLow type.FeatureFlaw
original: nikkiDEEE/ped#7

As seen in the image, I am able to add 2 modules of the same name if I add additional space at the end

Labels: type.FunctionalityBug severity.Low
original: darrenangwx/ped#3

I've added modules according to the user guide, but I am unable to see any modules when 'list' command was typed. I think this bug only occurs when using the taken command and I add in a module that does not exists (e.g. abcde). For plan adding in a module that does not exist will still allow me to list all modules.

I think if I added mods that are not in NUSMods, the list command will show null as a result.

Labels: type.FunctionalityBug severity.Low
original: darrenangwx/ped#1

Negative integer as input to year is being accepted by the program. This is incorrect as university year cannot be negative.

Labels: severity.High type.FunctionalityBug
original: TopGun2001/ped#1

There is a module named ES2631 but there is no information regarding the module.

Labels: type.FeatureFlaw severity.Medium
original: TopGun2001/ped#5

Technically these are the same inputs but we get different outputs. It's recommended to trim out the extra spaces entered by the user accidentally.

Labels: type.FeatureFlaw severity.Low
original: TopGun2001/ped#6

Integer has been keyed in but it says c/ must be an integer.

Perhaps use a string manipulation technique like .trim() to remove the trailing whitespace.

Either that or the error prompt has to be changed from "... valid integer" to " ... valid input" and prompt the user to not leave any leading/ trailing white spaces.

Labels: severity.Low type.FeatureFlaw
original: nikkiDEEE/ped#5

1. Can remove code if it is unused.

Can a user have a number as a name?

Labels: severity.VeryLow type.FeatureFlaw
original: nikkiDEEE/ped#4

ListParser formatting issues and not printing semester cap for list y/ s/

1. Steps to reproduce:

>taken CS2113 y/1 s/1 g/A

>list

>list y/1

>list y/1 s/1

2. Expected:
   *List the modules I have chosen

3. Actual:

1 error message.

4. Screenshots

Labels: type.FunctionalityBug severity.High
original: seawolf1024/ped#1

1. Unsure what the <p> tag is in the comments.

Steps to reproduce:

• Add 1 taken module with invalid module code: taken abcd y/2023 s/1 g/A,

Expected behavior: print that such module does not exist

Actual behavior: prints "added module"

Screenshot:

Labels: type.FeatureFlaw severity.Medium
original: DavidVin357/ped#1