Version stays at 1 about kvs

[azu]

kvs/packages/storage/src/storage.ts

Lines 120 to 131 in 7b4953e

	// if user set newVersion, upgrade it
	if (oldVersion !== version) {
	return Promise.resolve(
	onUpgrade({
	oldVersion,
	newVersion: version,
	storage
	})
	).then(() => {
	return storage;
	});
	}

Maybe, we need to write version to storage.

TODO

• Add tests
• Fix storage implementation

[azu]

Can you provide reproduce example?

browser:

(async () => {
  const { kvsEnvStorage } = await import("https://cdn.skypack.dev/@kvs/[email protected]");
  const storage = await kvsEnvStorage({
    name: "database-name",
    version: 2,
    async upgrade({ kvs, oldVersion, newVersion }) {
      console.log({
        oldVersion, // 0
        newVersion // 2
      });
    }
  });
})();

node:

https://replit.com/@azu2/kvs-env-new-version?v=1#index.js

[Kalabasa]

It is reproducible it in your node replit example. Check ~/kvs-env-new-version/.cache/kvs-node-localstorage/database-name.__.__kvs_version__. Version is always 1, regardless of the version in the app.

[Kalabasa]

Another example:
https://replit.com/@Kalabasa-/kvs-env-new-version#index.js

[azu]

Fixed in https://github.com/azu/kvs/releases/tag/v2.1.3