azure-samples / ms-identity-javascript-angular-spa-dotnetcore-webapi-roles-groups

Angular single-page application (SPA) calling .NET Core web API using App Roles and Security Groups for Implementing Role-Based Access Control (RBAC) using MSAL Angular

Angular single-page application (SPA) calling a protected web API and using App Roles and Security Groups

There's a newer version of this sample taking advantage of Angular 11 and MSAL Angular v2.

Check it out:

• Angular single-page application calling .NET Core web API using App Roles
• Angular single-page application calling .NET Core web API using Security Groups

If you really need to access this sample, you can navigate to the master branch, but please know that it's no longer maintained.

ms-identity-javascript-angular-spa-dotnetcore-webapi-roles-groups's Issues

Link to Chapter 1 is broken

In the general readme.md of this sample, in step 2, the link to "Chapter 1" leads to a 404.
I found chapter 1 here: https://github.com/Azure-Samples/ms-identity-javascript-angular-spa-dotnetcore-webapi-roles-groups/tree/master/chapter1

The current link pointing to chapter one is: https://github.com/Azure-Samples/ms-identity-javascript-angular-spa-dotnetcore-webapi-roles-groups/blob/master/Chapter1/README.md

Is a client_secret needed to run the SPA example and where to get it?

Library

• @azure/[email protected]
• @azure/[email protected]

Description

I been following the instruction to run the example from chapter 1. But I keep getting error below when trying to login. It seem that I'm missing a setting for the client_secret, where would I get that and where does it need to be entered? I only see the setting in the appsettings.json in the API.

claims: "{"access_token":{"capolids":{"essential":true,"values":["29ab2b01-4103-4857-b082-bbd11047e33b"]}}}"
correlation_id: "af402f90-a33d-42aa-a1de-ecdf57ddd62c"
error: "invalid_client"
error_codes: [7000218]
0: 7000218
error_description: "AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'.
↵Trace ID: 718bbd59-3d47-480c-820b-8be8fc8c9400
↵Correlation ID: af402f90-a33d-42aa-a1de-ecdf57ddd62c
↵Timestamp: 2021-03-26 19:07:05Z"
error_uri: "https://login.microsoftonline.com/error?code=7000218"
timestamp: "2021-03-26 19:07:05Z"
trace_id: "718bbd59-3d47-480c-820b-8be8fc8c9400"

Slight documentation tweak - TaskUser vs TaskUsers

Hello,
I think there is an error in the Chapter1 sample ReadMe.md . It states to add this to the manifest

      {
         "allowedMemberTypes": [
            "User"
         ],
         "description": "Users can read and modify their TodoList but cannot see others' lists",
         "displayName": "TaskUsers",
         "id": "a816142a-2e8e-46c4-9997-f984faccb625",
         "isEnabled": true,
         "lang": null,
         "origin": "Application",
         "value": "TaskUsers"
      }

In the code it checks for the singular TaskUser where the role added is the plural TaskUsers. Once I changed the manifest to the singular, things worked out. I'd make the change in the readme.md, but I've never made an open source contribution before. I'm not exactly sure how to do it correctly.

Chapter 1 TodoListSPA source code fails to build

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

• "@azure/msal-angular": "^2.0.0-alpha.0"

Framework

Description

These lines throw an error:
this.authService.loginPopup({...this.msalGuardConfig.authRequest})
this.authService.loginRedirect({...this.msalGuardConfig.authRequest});

Error Message

error TS2345: Argument of type '{ prompt?: string | undefined; state?: string | undefined; authority?: string | undefined; correlationId?: string | undefined; claims?: string | undefined; resourceRequestMethod?: string | undefined; ... 10 more ...; scopes?: string[] | undefined; } | { ...; }' is not assignable to parameter of type 'PopupRequest | undefined'.
Type '{ prompt?: string | undefined; state?: string | undefined; authority?: string | undefined; correlationId?: string | undefined; claims?: string | undefined; resourceRequestMethod?: string | undefined; ... 10 more ...; scopes?: string[] | undefined; }' is not assignable to type 'PopupRequest'.
Type '{ prompt?: string | undefined; state?: string | undefined; authority?: string | undefined; correlationId?: string | undefined; claims?: string | undefined; resourceRequestMethod?: string | undefined; ... 10 more ...; scopes?: string[] | undefined; }' is not assignable to type '{ scopes: string[]; }'.
Types of property 'scopes' are incompatible.
Type 'string[] | undefined' is not assignable to type 'string[]'.
Type 'undefined' is not assignable to type 'string[]'.

Security

• Is this issue security related?

Regression

• Did this behavior work before?

Version:

MSAL Configuration

// Provide configuration values here.
// For Azure B2C issues, please include your policies.

Reproduction steps

Download TodoListSPA
npm install
ng build --prod

// Provide relevant code snippets here.
// For Azure B2C issues, please include your policies.

Expected behavior

The source code would build successfully

Browsers/Environment

• Chrome
• Firefox
• Edge
• Safari
• IE
• Other (Please add browser name here)