Compose error details are not propagated to Ibiza or CLI about azure-docker-extension

[ahmetb]

@alinamstanciu this is mostly because we directly invoke docker-compose binary, which prints arbitrary output instead of a structured one. I believe we should not rely on their output format and try to parse out something meaningful.

Here is a failure:

Pulling sleep (busyboxs:latest)...
Error: image library/busyboxs not found

Here is another:

Validation failed in file '/etc/docker/compose/docker-compose.yml', reason(s):
Unsupported config option for 'sleep' service: 'commands'

As you see, totally unstructured.

Would a better error message such as docker-compose failed with exit code 1, check out /var/log/.../docker-extension.log be more helpful to you?

[vishwam]

Would it be possible to just pass-through the stderr contents when the exit code is not 0? Otherwise, the error message you suggested is good as well.
(Also, since docker-compose can be flakey at times, could you add some logic to retry docker-compose a second time in case of failure?)

[ahmetb]

@vishwam For now I just added the path of the log file that contains the docker-compose error to the error message that goes to the portal. This is effective in v1.1.1606092330

I have some concerns about adding retries as re-running docker-compose up has certain semantics about already running containers. Also, adding retries here would increase end-to-end execution time of the extension and if the containers cannot be pulled again on the second retry, it doesn't exactly make things any better. So I'm not quite sure how many retries with what kind of backoff strategy we need here.

Feel free to open another issue if not having retries in docker-compose up really impacts you.