Comments (2)
Some notes on this investigation:
- Azure.Core RequestHeaders has a TryGetValues(IEnumerable) overload. We could move the implementation of this into Azure.Core only, but it would mean splitting the implementation of RequestHeaders across libraries.
- System.Net.Http HttpHeaders has only the TryGetValues(IEnumerable) overload, but it also has an Add(string, IEnumerable), so the type doesn't necessarily have to allocate the collection itself
- Having
TryGetValue(string name, out string? value)
side by side withTryGetValues(string name, out IEnumerable<string>? values)
is a nice clue to the caller that the header value can be multi-valued. This doesn't appear to be common knowledge from some of the conversations I've had recently. - We have this code in Azure.Core today, so this is an opportunity to improve performance in ClientModel, but shouldn't represent a regression to performance with the current implementation
- I wonder, if there was an efficient way to split over char buffers, if we could support the IEnumerable API without the need to allocate a collection?
- There are some nice optimizations to the System.Net.Http implementation here. Maybe we continue to support this API in the current state for now to make it easy to have a single implementation across Azure.Core and ClientModel, and come back and optimize it later?
from azure-sdk-for-net.
Closing per offline conversation
from azure-sdk-for-net.
Related Issues (20)
- [FEATURE REQ] OpenRead for BlockBlob should return properties HOT 2
- [Question]MetaData when adding AzureCognitiveSearchChatExtensionConfiguration option vector option HOT 2
- external chat that sends and receives messages from Teams channel with Azure Communication Services HOT 1
- ClientModel: Review Azure.Core 2.0 PR prior to final ClientModel release HOT 1
- Support pagination for CostManagement Query Usage HOT 3
- [FEATURE REQ] Add link/docs on Azure SDK instrumentation to otel dotnet contrib repo
- Test Improvements for Monitor Libraries
- [FEATURE REQ] Support SDK generation in CI pipeline for the services migrated from Swagger to TypeSpec HOT 1
- [BUG] BCL AsyncInterfaces runtime error on upgrade - Azure.Monitor.OpenTelemetry.AspNetCore 1.1.0 HOT 6
- [QUERY] Asynchronous operations failing unexpectedly HOT 4
- [BUG] EventHubListener causes message lost in shutdown HOT 11
- [FEATURE REQ]: Support passing the fully qualified name to the service bus client without having to trim it HOT 1
- [QUERY] Use MangedIdentity to access Azure SQL Server. Microsoft.Data.SqlClient.SqlException (0x80131904): The operation was canceled. HOT 1
- Looking for a slightly more detailed explanation of blob authorization HOT 5
- [BUG] Azure.Storage.Blobs SDK considers &spr=http,https as invalid SasProtocol HOT 2
- [QUERY] Why isn't there a AddClient overload that accepts an async factory? HOT 3
- [ContainerApp] Create Container app failed for accessing ACR with user identity HOT 1
- [BUG] Serialization Issue caused by MapsAddress.get_BoundingBox() HOT 1
- [BUG] Azure.Messaging.ServiceBus Version 7.17.x Causing High Request Rates, Performance Issues, and Escalating Billing Costs HOT 4
- [QUERY] Need to filter out Blob response using SDK
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-sdk-for-net.