GithubHelp home page GithubHelp logo

Comments (5)

github-actions avatar github-actions commented on July 29, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cijothomas @rajkumar-rangaraj @reyang @TimothyMothra @vishweshbankwar.

from azure-sdk-for-net.

github-actions avatar github-actions commented on July 29, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cijothomas @rajkumar-rangaraj @reyang @TimothyMothra @vishweshbankwar.

from azure-sdk-for-net.

drilko avatar drilko commented on July 29, 2024

Okay, after doing a bit of research I guess I was a bit confused due to design.
Microsoft.Extensions.Logging.ApplicationInsights includes logger scopes by default, while Azure.Monitor.OpenTelemetry.AspNetCore does not.

My questions is then: Is this intentional?
If yes, I would suggest just some documentation about this behavior as a lot of developers will be migrating and a hint about it would greatly help.

from azure-sdk-for-net.

cijothomas avatar cijothomas commented on July 29, 2024

Scopes are not enabled by default in OpenTelemetry, so it is expected that one must enable them explicitly to get scopes flowing to any exporter, including AzureMonitor. However, https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs#L132 is surprising.. Not sure why the distro explicitly have to disable it..

from azure-sdk-for-net.

TimothyMothra avatar TimothyMothra commented on July 29, 2024

This is by design. This is an opt-in feature and you're using the correct setting to enable:

builder.Services.Configure<OpenTelemetryLoggerOptions>(options =>
{
    options.IncludeScopes = true;
});

Thanks for your feedback. This behavior is different from Application Insights SDK and we'll update our public documentation.

from azure-sdk-for-net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.