GithubHelp home page GithubHelp logo

Comments (10)

MaxKhlupnov avatar MaxKhlupnov commented on May 29, 2024 2

Thanks, @jtaubensee !
0.0.5-preview installed successfully from NuGet and compiled in my Xamarin project (Android and UWP).

from azure-service-bus-dotnet.

jtaubensee avatar jtaubensee commented on May 29, 2024 1

Thanks @onovotny - We can work with that! Expect something after the new year.

from azure-service-bus-dotnet.

clairernovotny avatar clairernovotny commented on May 29, 2024 1

@jtaubensee I'm always happy to help and/or review things, just ping me whenever :)

from azure-service-bus-dotnet.

terrajobst avatar terrajobst commented on May 29, 2024

I second Oren's assessment -- it would be good to avoid the hard dependency on ref-emit. In some cases, you might get away with expression trees as UWP supports those using interpretation. Otherwise, cross-compilation might be the best option.

I'm happy to meet and discuss options.

from azure-service-bus-dotnet.

jtaubensee avatar jtaubensee commented on May 29, 2024

@onovotny, @terrajobst - The library will actually build without the System.Reflection.Emit reference, so I think it was inadvertently kept in the dependencies. Without knowing too much about UWP, if we remove that reference, will we still need to explicitly add the following?

  "uap10.0": {
    "dependencies": {
      "Microsoft.NETCore.UniversalWindowsPlatform": "5.2.2
    }

cc @vinaysurya

from azure-service-bus-dotnet.

clairernovotny avatar clairernovotny commented on May 29, 2024

@jtaubensee I believe the Sys.Ref.Emit was the only issue, but the easiest way to test is to create a UWP project and try to install the package :) It'll fail on restore if there's an issue. I don't think you'd need a UWP version.

One suggestion: you may want to use NETStandard.Library 1.6.1 as your baseline reference as that does resolve some issues installing into some Xamarin profiles that 1.6.0 had. You're likely to get issues with people trying to use the library with Xamarin projects otherwise.

Lastly, you also may want an .rd.xml file with any runtime directives for .net native. Those can be hard to determine, but it is possible to test if you run the unit tests on a release mode build of the xUnit for Devices UWP runner:

http://xunit.github.io/docs/getting-started-devices-uwp.html 

For truly testing .NET Native, you do need to alter the default .rd.xml that comes with the UWP project to look something like this:
https://github.com/Reactive-Extensions/Rx.NET/blob/master/Rx.NET/Source/Tests.System.Reactive.Uwp.DeviceRunner/Properties/Default.rd.xml

You can see how we verify this for Rx.NET on a UWP runner here:
https://github.com/Reactive-Extensions/Rx.NET/tree/master/Rx.NET/Source/Tests.System.Reactive.Uwp.DeviceRunner

We share all of the unit tests with .NET Core / .NET Desktop and just run them in release mode on .NET Native. 

from azure-service-bus-dotnet.

jtaubensee avatar jtaubensee commented on May 29, 2024

On hold until #87 is closed.

from azure-service-bus-dotnet.

MaxKhlupnov avatar MaxKhlupnov commented on May 29, 2024

Any progress on this? Still getting errors: System.Reflection.Emit.ILGeneration 4.3.0 when trying install NuGet for UWP target

from azure-service-bus-dotnet.

jtaubensee avatar jtaubensee commented on May 29, 2024

@MaxKhlupnov - I've just submitted PR #150 to add an output for this, so we should have this in our next release. Please keep in mind, that we have not fully tested this yet.

from azure-service-bus-dotnet.

jtaubensee avatar jtaubensee commented on May 29, 2024

Closing based on #150

from azure-service-bus-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.