iOS crashes when trying to initiate another call (after hanging up on the first one) about communication

[sankum-msft]

@tompi : This error indicates that previous ACSRenderer object for that LocalVideoStream/VideoDeviceInfo is not yet disposed. Your message also backs up this hypothesis. Please try disposing ACSRenderer. You don't need to dispose the view; disposing renderer disposes view as well.

But, agreed that this should not be a crash. I have created task to handle this gracefully and raise a more appropriate error.

[raosanat]

Hi @tompi Can you give more information, like

1. How often is this reproducible ?
2. Exact steps, API calls done to repro the issue
3. Can you attach the logs ?

Steps to get logs

1. In Xcode, go to Windows -> Devices and Simulators -> Devices -> Select your device -> Under Installed Apps -> Select your application -> Select at the bottom the settings icon -> Download container
2. You will get a file with extension xcappdata, Right-Click and select “Show package contents”
3. Go to Appdata->Library->Caches and upload the .blog files

[tompi]

@raosanat This crash was probably due to not disposing the renderers and/or the videostream after a call hangup. Works fine after I started doing that.

[tompi]

@raosanat : Sorry, seems this is still happening.

I spent some time debugging, and it seems to happen every time I try to make an ACSRendererView from the local video stream(works fine first time, but not the second time). Even though I dispose this, and most of the others, I only reuse ACSDeviceManager, ACSCallClient and ACSCallClient, that should be fine right?

Anyway, exception is still the same, but I attached it and also the complete logs.
I suspect this is your code that is throwing, but I can figure out why...:

*** Assertion failure in virtual void PreviewVideoRenderedBindingEvent::OnBindingFailed()(), /Volumes/ServerHD2/agent/_work/1/s/SpoolCallingStack/spool/sdk/iOS/ACSCallingSDK/SKPPullVideoRenderer/SKPPreviewVideoRenderer.mm:95

log.txt
stacktrace.txt

[tompi]

@sankum-msft Hey, I did some more debugging on this, and I cant make it work. I tried disposing ACSRenderer, but same problem. I then tried disposing every object: ACSRenderer, ACSLocalVideoStream, ACSCall, ACSCallAgent, ACSDeviceManager and the ACSCallClient.

I could NOT manage to dispose the ACSCallClient: the app just hangs(indefinitely...). SO my theory is that the ACSCallClient is hanging on to some resource which makes the second group-call crash. If you have tested this on your end, Im probably doing something wrong(but I really have a minimal setup now... Is there a specific sequence I need to dispose all the objects in to make this work? (If you have some example code in which multiple sequential calls work that would be great!)

[raosanat]

Hi @tompi if you download your app data there will be a file called "acs_sdk.blog" in Caches folder, can you attach that ?

[tompi]

Hey @raosanat , sorry about the delay, I downloaded the container, zipped it and attached to message:
acs-container.zip

[tompi]

Just to be clear: this happens when I make two consecutive calls to the same group.
I dispose everything, except the ACSCallAgent, since trying to dispose this object just hangs the app(no crash, just hang)

[tompi]

@raosanat and @sankum-msft : I just figured out that this was entirely my own fault... Sorry!
I had commented out the dispose method in the bindings(due to a warning). Once I commented in this I can du multiple calls fine after disposing the renderer.

My fix is here if you are curious: Laerdal/Xamarin.AzureCommunicationCalling@d68a94f

Again, sorry about wasting your time :(

[raosanat]

Good to know, that's ok 👍