GithubHelp home page GithubHelp logo

Comments (9)

hosungsmsft avatar hosungsmsft commented on July 20, 2024

My understanding is that it has been always the case, and being addressed by the Virtual Network Service Endpoints. It wasn't available on the region I wanted with Azure SQL when I needed earlier, but it seems like at least Azure SQL is available as preview for this feature in all regions. Not sure when MySQL & Postgres will be supported.

from moodle.

SorraTheOrc avatar SorraTheOrc commented on July 20, 2024

OK, so it's a "feature" not a "bug" I'll change the labels and drop to P1 as it seems we can't do anything about it right now.

from moodle.

hosungsmsft avatar hosungsmsft commented on July 20, 2024

Still, I think the template should be enhanced so that the database endpoint IP is not exposed to world (0.0.0.0-255.255.255.255), which is the current DB firewall setting. I'm not sure, though, how easy it would be to pass the obtained public IP of the load balancer to the firewall rule.

from moodle.

SorraTheOrc avatar SorraTheOrc commented on July 20, 2024

This was closed due to a commit message that said it "partially fixes", so re-opening.

@hosung having "fixes #issue_number" in a commit message will close the issue, so if it is a partial fix you need a different note (e.g. "applies to #" or something similar)

from moodle.

hosungsmsft avatar hosungsmsft commented on July 20, 2024

I know that, but I personally think that tightening up the firewall to the only public IPs from a deployed cluster is really enough for us, at least for now. Besides, the vnet service endpoint for MySQL/PostgreSQL won't come any time soon. Leaving this open is just fine with me anyway. We probably should fix the diagram to not confuse customers with strange terms like "public subnet".

from moodle.

SorraTheOrc avatar SorraTheOrc commented on July 20, 2024

OK, so it's not a "partial fix"? I only re-opened because of the word "partial". Happy to close again.

from moodle.

hosungsmsft avatar hosungsmsft commented on July 20, 2024

I said it's "partial" in that the issue statement is "Why the database is on a public subnet?" and this fix doesn't move the DB to the private vnet using the Azure vnet service endpoints feature (which is not available for Azure MySQL/PostgreSQL for now). It still configures the DB on an Azure public IP (we really don't have a separate public subnet in our deployment), but all access to the DB is rejected except for our 2 public IP addresses (from the VMSS load balancer and the controller VM).

from moodle.

nimojg-microsoft avatar nimojg-microsoft commented on July 20, 2024

@hosungsmsft VNET Service endpoints for MySQL and PostgreSQL are now in preview - https://azure.microsoft.com/en-us/blog/vnet-service-endpoints-for-azure-database-services-for-mysql-and-postgresql-in-preview/

Should we reopen this issue? Think it might be a good one for the community to address.

from moodle.

nimojg-microsoft avatar nimojg-microsoft commented on July 20, 2024

@hosungsmsft Just an FYI - VNet Service endpoints are now GA in case this work is still planned. Currently there is no open issue for this in case we want to reopen this.

from moodle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.